From: Jon Hunter <jonathanh@nvidia.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
Svyatoslav Ryhel <clamor95@gmail.com>
Subject: Re: [PATCH V2] clk: tegra: Fix Tegra PWM parent clock
Date: Mon, 10 Oct 2022 11:03:27 +0100 [thread overview]
Message-ID: <942e4d27-a68f-9ce2-0523-75f8e57acdd3@nvidia.com> (raw)
In-Reply-To: <20221009081853.6ipyu7u3ghcp6dfo@pengutronix.de>
On 09/10/2022 09:18, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Oct 07, 2022 at 09:45:24AM +0100, Jon Hunter wrote:
>> Commit 8c193f4714df ("pwm: tegra: Optimize period calculation") updated
>> the period calculation in the Tegra PWM driver and now returns an error
>> if the period requested is less than minimum period supported. This is
>> breaking PWM support on various Tegra platforms. For example, on the
>> Tegra210 Jetson Nano platform this is breaking the PWM fan support and
>> probing the PWM fan driver now fails ...
>>
>> pwm-fan pwm-fan: Failed to configure PWM: -22
>> pwm-fan: probe of pwm-fan failed with error -22
>>
>> The problem is that the default parent clock for the PWM on Tegra210 is
>> a 32kHz clock and is unable to support the requested PWM period.
>>
>> Fix PWM support on Tegra20, Tegra30, Tegra124 and Tegra210 by updating
>> the parent clock for the PWM to be the PLL_P.
>>
>> Fixes: 8c193f4714df ("pwm: tegra: Optimize period calculation")
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>
> First of all, thanks for your fix. Very appreciated.
No problem.
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks. I have just sent a V3 because I was missing a fix for Tegra114.
Can you ACK that one as well?
> Who will take care for this patch? I assume it will be Stephen and
> Michael (i.e. the clk maintainers)? Do you consider this patch fine for
> application before the next merge window, or do you expect that it might
> break other use cases and so should cook in next for some time?
We should pick this up as a fix for v6.1. I also plan to request this is
pulled into stable as well (all going well).
Cheers
Jon
--
nvpublic
prev parent reply other threads:[~2022-10-10 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 8:45 [PATCH V2] clk: tegra: Fix Tegra PWM parent clock Jon Hunter
2022-10-07 10:21 ` Thierry Reding
2022-10-09 6:50 ` Thomas Graichen
2022-10-09 8:18 ` Uwe Kleine-König
2022-10-10 10:03 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942e4d27-a68f-9ce2-0523-75f8e57acdd3@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=clamor95@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox