public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Marek Vasut <marex@denx.de>, linux-clk@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>, Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH 2/2] clk: si521xx: Fix regmap write accessor
Date: Mon, 11 Sep 2023 13:50:04 -0700	[thread overview]
Message-ID: <9434b9e6b7f60c308df5b1f28edbbe5c.sboyd@kernel.org> (raw)
In-Reply-To: <20230831181656.154750-2-marex@denx.de>

Quoting Marek Vasut (2023-08-31 11:16:56)
> Rework the write operation such that the Byte Count register is written with
> a single raw i2c write outside of regmap using transfer which does specify
> the number of bytes to be transfered, one in this case, and which makes the
> expected subsequent write transfer look like address+register+data, and then
> make use of this method. Without this change, the Byte Count register write
> in probe() would succeed as it would provide the byte count as part of its
> write payload, but any subsequent writes would fail due to this Byte Count
> register programming. Such failing writes happens e.g. during resume, when
> restoring the regmap content.
> 
> Fixes: edc12763a3a2 ("clk: si521xx: Clock driver for Skyworks Si521xx I2C PCIe clock generators")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---

Applied to clk-fixes

  reply	other threads:[~2023-09-12  3:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 18:16 [PATCH 1/2] clk: si521xx: Use REGCACHE_FLAT instead of NONE Marek Vasut
2023-08-31 18:16 ` [PATCH 2/2] clk: si521xx: Fix regmap write accessor Marek Vasut
2023-09-11 20:50   ` Stephen Boyd [this message]
2023-09-11 20:49 ` [PATCH 1/2] clk: si521xx: Use REGCACHE_FLAT instead of NONE Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9434b9e6b7f60c308df5b1f28edbbe5c.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox