From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "Stephen Boyd" <sboyd@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Russell King" <linux@armlinux.org.uk>
Cc: kernel@collabora.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/4] clk: Provide devm_clk_bulk_get_all_enabled() helper
Date: Sat, 19 Oct 2024 14:20:18 +0300 [thread overview]
Message-ID: <9455cce5-af97-48cb-8042-24b714f29401@collabora.com> (raw)
In-Reply-To: <c0afdf9f8c9773ef83274cb119d14c90.sboyd@kernel.org>
On 10/19/24 8:56 AM, Stephen Boyd wrote:
> Quoting Cristian Ciocaltea (2024-10-17 16:17:29)
>> diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c
>> index 82ae1f26e634572b943d18b8d86267f0a69911a6..0d0fe364b66a8590d5e7c63dc6c1e70c59d53e89 100644
>> --- a/drivers/clk/clk-devres.c
>> +++ b/drivers/clk/clk-devres.c
>> @@ -230,25 +239,27 @@ int __must_check devm_clk_bulk_get_all_enable(struct device *dev,
>> return -ENOMEM;
>>
>> ret = clk_bulk_get_all(dev, &devres->clks);
>> - if (ret > 0) {
>> - *clks = devres->clks;
>> - devres->num_clks = ret;
>> - } else {
>> - devres_free(devres);
>> - return ret;
>> - }
>> + if (ret <= 0)
>> + goto err_free_devres;
>
> Please don't use goto so that the diff is minimized.
Done in v4:
https://lore.kernel.org/all/20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com/
Regards,
Cristian
next prev parent reply other threads:[~2024-10-19 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 23:17 [PATCH v3 0/4] Provide devm_clk_bulk_get_all_enabled() helper Cristian Ciocaltea
2024-10-17 23:17 ` [PATCH v3 1/4] clk: " Cristian Ciocaltea
2024-10-19 5:56 ` Stephen Boyd
2024-10-19 11:20 ` Cristian Ciocaltea [this message]
2024-10-17 23:17 ` [PATCH v3 2/4] soc: mediatek: pwrap: Switch to devm_clk_bulk_get_all_enabled() Cristian Ciocaltea
2024-10-17 23:17 ` [PATCH v3 3/4] PCI: exynos: " Cristian Ciocaltea
2024-10-17 23:17 ` [PATCH v3 4/4] clk: Drop obsolete devm_clk_bulk_get_all_enable() helper Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9455cce5-af97-48cb-8042-24b714f29401@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox