From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sam Protsenko <semen.protsenko@linaro.org>,
linux-clk <linux-clk@vger.kernel.org>
Cc: "David Virag" <virag.david003@gmail.com>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>
Subject: Re: [PATCH v2 1/1] clk: samsung: exynos850: Register clocks early
Date: Mon, 22 Nov 2021 23:04:13 +0100 [thread overview]
Message-ID: <95864889-e80b-e627-7b63-1079caa0fa12@samsung.com> (raw)
In-Reply-To: <20211122144206.23134-1-semen.protsenko@linaro.org>
On 22.11.2021 15:42, Sam Protsenko wrote:
> Some clocks must be registered before init calls. For example MCT clock
> (from CMU_PERI) is needed for MCT timer driver, which is registered
> with TIMER_OF_DECLARE(). By the time we get to core_initcall() used for
> clk-exynos850 platform driver init, it's already too late. Inability to
> get "mct" clock in MCT driver leads to kernel panic, as functions
> registered with *_OF_DECLARE() can't do deferred calls. MCT timer driver
> can't be fixed either, as it's acting as a clock source and it's
> essential to register it in start_kernel() -> time_init().
>
> Let's register CMU_PERI clocks early, using CLK_OF_DECLARE(). CMU_TOP
> generates clocks needed for CMU_PERI, but it's already registered early.
>
> While at it, let's cleanup the code a bit, by extracting everything
> related to CMU initialization and registration to the separate function.
Applied, thanks.
next prev parent reply other threads:[~2021-11-22 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211122144217eucas1p21c5f4930563ee051d625bb8e3a932a4a@eucas1p2.samsung.com>
2021-11-22 14:42 ` [PATCH v2 1/1] clk: samsung: exynos850: Register clocks early Sam Protsenko
2021-11-22 22:04 ` Sylwester Nawrocki [this message]
[not found] <CGME20211025161302eucas1p2f50ef29a0bba69c13deaf1ad31a8439c@eucas1p2.samsung.com>
2021-10-25 16:12 ` Sam Protsenko
2021-10-26 14:53 ` Krzysztof Kozlowski
2021-11-20 12:49 ` Sylwester Nawrocki
2021-11-20 16:47 ` Sam Protsenko
2021-11-20 17:38 ` Sylwester Nawrocki
2021-11-21 22:50 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95864889-e80b-e627-7b63-1079caa0fa12@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox