From: Heiner Kallweit <hkallweit1@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH] clk: change clk_hw_create_clk() to avoid being unable to remove module
Date: Tue, 18 Apr 2023 23:03:08 +0200 [thread overview]
Message-ID: <963d9e46-936e-bb38-aa92-38b8c36a3aaa@gmail.com> (raw)
In-Reply-To: <efc9ee0c7c790566d242a2561ac55a55.sboyd@kernel.org>
On 18.04.2023 02:43, Stephen Boyd wrote:
> Quoting Heiner Kallweit (2023-04-13 23:01:13)
>> On 14.04.2023 00:29, Stephen Boyd wrote:
>>> Quoting Heiner Kallweit (2023-04-13 14:39:28)
>>>> With clk_hw_create_clk() we have the problem that module unloading
>>>> is impossible if consumer and provider module owner are the same and
>>>> refcount is incremented. See also following comment in __clk_register().
>>>
>>> Do you never call clk_put() on the clk that you get from
>>> clk_hw_create_clk()?
>>
>> In my case clk_put() is called from a devm release hook. Same issue
>> we'd have if clk_put would be called from the drivers remove callback.
>> clk_put would be unreachable because the incremented module refcount
>> prevents module removal.
>>
>
> Ok. You could unbind the device in sysfs though, right?
I *think* this should be possible, right.
prev parent reply other threads:[~2023-04-18 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 21:39 [PATCH] clk: change clk_hw_create_clk() to avoid being unable to remove module Heiner Kallweit
2023-04-13 22:29 ` Stephen Boyd
2023-04-14 6:01 ` Heiner Kallweit
2023-04-18 0:43 ` Stephen Boyd
2023-04-18 21:03 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963d9e46-936e-bb38-aa92-38b8c36a3aaa@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox