From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2845525632; Fri, 2 Aug 2024 19:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722626742; cv=none; b=MG5mEjBFEBuYS9yFDhdUGDncI3dwvUbI0WCyGIzWePA3Di9jBnpKgGjaNQK2ksVt7S34evrBTHjvT7nQB6oEa31NdnRHtmq6KBKNtZ8sa+AqKDaydSI6EIeganORkjn8v4GS5+u2pQIhd9h1EbnK4uIvwKRz0ZX3wCJNnz3oE4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722626742; c=relaxed/simple; bh=WSzeNRd0SlFLq2fEu6JscOO47OidJJK0twz4AIyvMK0=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=DUpJXTvQrvgboZXgSkJ7nPT/U/IHEDv5S6wFPJLcQDRG5Vu+cw52C+AKANyfpfRyP15cvVxbTCpikRvVtVYbfv91vRZxt21pXKyJXXn5wL5Pb3SvQbr5ia4Trn+UYLHT9rpCdfUtpohVwtiLPOqMbpO7XkkpnFh7A5rCeda8YUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=bkNilIFm; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=erPfkcNu; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="bkNilIFm"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="erPfkcNu" Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 34912114836A; Fri, 2 Aug 2024 15:25:39 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute4.internal (MEProxy); Fri, 02 Aug 2024 15:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1722626739; x=1722713139; bh=KPWpdBe/T1YEYhELoEmhOZAJmkQnlBGJanxmk1YGIuE=; b= bkNilIFm7jHFTG21pN96yxq5at/ynSJ0aE9B30By9sJdeORKNRVPtesIItlO2F4i xTx/vAFmh6B/b3hlf/o6VoDjyBgstfm2F3yKGAd4rjO4ZyoE5J8aQNkd/pFynocd qv/EsJSWYHJ1Otug4POEnkMh9VR58EBN0FwPPMdMnNz91/9dcoa+CMRUF6MxwGBw jfCfGN6zCNdlOoyEOEv016SDQXukBNflql9arXxmceGiquvp+bW1ygSVEJG4Nnkv cc+jBiQfKsVgcKycEmx8IK73OAlDFpnUv5tLhpRIbA5WVb80Qkhnbg0aYHwNA4zP TPArDCWhwFCRE9h89hNKxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722626739; x= 1722713139; bh=KPWpdBe/T1YEYhELoEmhOZAJmkQnlBGJanxmk1YGIuE=; b=e rPfkcNuYhJzr3v3d7rMg/Mv+IbTYL/sTUGzhEDvuFKY8HHAsJu8wPsf55YiJx1kb 4JF4IlHI+FXcUbANvlW0R6rkdkjJs6nQV2Uj3CepmXhwR0OJvnPmthtZGkpo8S4Z 1F533P8AdsLfmH7LtQI7Zy+UE5X0L1iNkOOlGo/TW0oF8SaGVia80pFnj3LszEgY 8jLMck8NSt1/JHNcd2QAguinfBQjbvs4lbouWc/24GS9CgJBaqgbr7CtNhbAoBTb BWGW+GbAmjnQs7EIPFPaReDjK9MckNS+A+nRj6A2LZYlkbJt16isEIXFP06RtT5/ n3KrR1JQY3SS7w6SR2dsw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrkedtgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefh vdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 48551B6008D; Fri, 2 Aug 2024 15:25:37 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 02 Aug 2024 21:25:17 +0200 From: "Arnd Bergmann" To: "Dmitry Baryshkov" , "Kevin Chen" Cc: "Rob Herring" , krzk+dt@kernel.org, "Conor Dooley" , "Joel Stanley" , "Andrew Jeffery" , "Lee Jones" , "Catalin Marinas" , "Will Deacon" , "Olof Johansson" , soc@kernel.org, "Michael Turquette" , "Stephen Boyd" , "Philipp Zabel" , "Bjorn Andersson" , "Geert Uytterhoeven" , "Shawn Guo" , "Neil Armstrong" , "Marek Szyprowski" , =?UTF-8?Q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= , "Udit Kumar" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Message-Id: <9795437d-b409-4105-9583-4dcb24b5a06c@app.fastmail.com> In-Reply-To: References: <20240802090544.2741206-1-kevin_chen@aspeedtech.com> <20240802090544.2741206-9-kevin_chen@aspeedtech.com> Subject: Re: [PATCH v2 7/9] arm64: defconfig: Add ASPEED AST2700 family support Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, Aug 2, 2024, at 21:20, Dmitry Baryshkov wrote: > On Fri, 2 Aug 2024 at 12:05, Kevin Chen wrote: >> >> Enable CONFIG_ARCH_ASPEED in arm64 defconfig. > > Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is > used on the Bar Baz platform" commit message. I would also expect to see aspeed specific device drivers to get enabled in the same commit. On arm32, I see CONFIG_ASPEED_KCS_IPMI_BMC=m CONFIG_ASPEED_BT_IPMI_BMC=m CONFIG_I2C_ASPEED=m CONFIG_SPI_ASPEED_SMC=m CONFIG_GPIO_ASPEED_SGPIO=y CONFIG_SENSORS_ASPEED=m CONFIG_VIDEO_ASPEED=m CONFIG_DRM_ASPEED_GFX=m CONFIG_USB_ASPEED_VHUB=m CONFIG_RTC_DRV_ASPEED=m CONFIG_ASPEED_LPC_CTRL=m CONFIG_ASPEED_LPC_SNOOP=m CONFIG_ASPEED_P2A_CTRL=m CONFIG_ASPEED_ADC=m CONFIG_FSI_MASTER_ASPEED=m Presumably not all but a lot of these are also used on AST2700. Arnd