Re: [PATCH v2 3/6] dt-bindings: clock: qcom: Add CAMCC clocks for QCS8300

Vladimir Zapolskiy
2024-10-30T11:03:22Z

Imran, Krzysztof,

On 10/24/24 16:31, Imran Shaik wrote:
> The QCS8300 camera clock controller is mostly identical to SA8775P, but
> QCS8300 has one additional clock and minor differences. Hence, reuse the
> SA8775P camera bindings and add additional clock required for QCS8300.
>
> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
> ---
> Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml | 1 +
> include/dt-bindings/clock/qcom,sa8775p-camcc.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
> index 36a60d8f5ae3..18cbc23b9a07 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml
> @@ -18,6 +18,7 @@ description: |
> properties:
> compatible:
> enum:
> + - qcom,qcs8300-camcc
> - qcom,sa8775p-camcc
>
> clocks:
> diff --git a/include/dt-bindings/clock/qcom,sa8775p-camcc.h b/include/dt-bindings/clock/qcom,sa8775p-camcc.h
> index 38531acd699f..36ac587a981a 100644
> --- a/include/dt-bindings/clock/qcom,sa8775p-camcc.h
> +++ b/include/dt-bindings/clock/qcom,sa8775p-camcc.h
> @@ -93,6 +93,7 @@
> #define CAM_CC_SM_OBS_CLK 83
> #define CAM_CC_XO_CLK_SRC 84
> #define CAM_CC_QDSS_DEBUG_XO_CLK 85
> +#define CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK 86
>
> /* CAM_CC power domains */
> #define CAM_CC_TITAN_TOP_GDSC 0
>

I greately dislike this change, and the reasons are the same as already
given by Krzysztof.

If you find it possible, please follow an approach by adding a new
header file and include a platform ancestor headder file from it, like
it's done in commit a6a61b9701d1.

--
Best wishes,
Vladimir