From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH v2 08/10] clk: qcom: Add GPU clock driver for x1e80100
Date: Sat, 16 Dec 2023 14:35:45 +0100 [thread overview]
Message-ID: <993d76c7-ceab-4381-b63e-794c77f7d0df@linaro.org> (raw)
In-Reply-To: <20231214-x1e80100-clock-controllers-v2-8-2b0739bebd27@linaro.org>
On 14.12.2023 17:49, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>
> Add Graphics Clock Controller (GPUCC) support for X1E80100 platform.
>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
[...]
I see no usage of clk_branch2_aon_ops, is that intended?
[...]
> +static struct gdsc gpu_cc_cx_gdsc = {
> + .gdscr = 0x9108,
> + .gds_hw_ctrl = 0x953c,
> + .en_rest_wait_val = 0x2,
> + .en_few_wait_val = 0x2,
> + .clk_dis_wait_val = 0xf,
> + .pd = {
> + .name = "gpu_cc_cx_gdsc",
> + },
> + .pwrsts = PWRSTS_OFF_ON,
> + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
That's.. unusual..
Can you doublecheck these flags?
> +
> + /*
> + * Keep clocks always enabled:
> + * gpu_cc_cb_clk
> + */
> + regmap_update_bits(regmap, 0x93a4, BIT(0), BIT(0));
Please make the comment inline, so:
regmap_update_bits(regmap, 0x93a4, BIT(0), BIT(0)); /* GPU_CC_CB_CLK */
I have submitted another series cleaning this up and adding a helper
Konrad
next prev parent reply other threads:[~2023-12-16 13:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 16:49 [PATCH v2 00/10] clk: qcom: Add TCSR, GPU, CAM and DISP clock controllers for X1E80100 Abel Vesa
2023-12-14 16:49 ` [PATCH v2 01/10] dt-bindings: clock: Drop the SM8650 DISPCC dedicated schema Abel Vesa
2023-12-14 16:49 ` [PATCH v2 02/10] dt-bindings: clock: qcom: Document the X1E80100 Display Clock Controller Abel Vesa
2023-12-15 9:07 ` Krzysztof Kozlowski
2023-12-14 16:49 ` [PATCH v2 03/10] dt-bindings: clock: qcom: Document the X1E80100 GPU " Abel Vesa
2023-12-14 16:49 ` [PATCH v2 04/10] dt-bindings: clock: qcom: Document the X1E80100 TCSR " Abel Vesa
2023-12-14 16:49 ` [PATCH v2 05/10] dt-bindings: clock: qcom: Document the X1E80100 Camera " Abel Vesa
2023-12-14 16:49 ` [PATCH v2 06/10] clk: qcom: clk-alpha-pll: Add support for zonda ole pll configure Abel Vesa
2023-12-14 16:49 ` [PATCH v2 07/10] clk: qcom: Add dispcc clock driver for x1e80100 Abel Vesa
2023-12-15 12:45 ` Bryan O'Donoghue
2024-01-23 11:30 ` Abel Vesa
2023-12-16 13:32 ` Konrad Dybcio
2023-12-14 16:49 ` [PATCH v2 08/10] clk: qcom: Add GPU " Abel Vesa
2023-12-15 12:40 ` Bryan O'Donoghue
2024-01-23 11:43 ` Abel Vesa
2023-12-16 13:35 ` Konrad Dybcio [this message]
2023-12-14 16:49 ` [PATCH v2 09/10] clk: qcom: Add TCSR " Abel Vesa
2023-12-16 13:36 ` Konrad Dybcio
2023-12-14 16:49 ` [PATCH v2 10/10] clk: qcom: Add camcc " Abel Vesa
2023-12-15 12:38 ` Bryan O'Donoghue
2023-12-16 13:39 ` Konrad Dybcio
2024-01-23 11:49 ` Abel Vesa
2024-01-23 17:56 ` Konrad Dybcio
2024-01-24 9:22 ` Abel Vesa
2024-01-28 21:54 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=993d76c7-ceab-4381-b63e-794c77f7d0df@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox