From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97766C001DB for ; Wed, 5 Jul 2023 04:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjGEE1y (ORCPT ); Wed, 5 Jul 2023 00:27:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjGEE1x (ORCPT ); Wed, 5 Jul 2023 00:27:53 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7DB510F2; Tue, 4 Jul 2023 21:27:51 -0700 (PDT) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36541Olm027002; Wed, 5 Jul 2023 04:27:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=eYUVnt6Wi+jIiqMPQqigPy6gPw+ZrOvBJs+sKNwn0s0=; b=onNdyOX0UsACwxtosHgJ0YmEdC56WnQuijX9mPZUZV9RJLA90LKYtHoWM1SnmTlJPrU4 E3ygCB2XCfCGpADcRmUvS3eoY2VKQhTRyglDvl6XeluwQLaiLyMUAWg6Br21dtIfnSF6 tZUK3wCO89TA+91NOCfLx1EHld3BZrH9HRs6owe4B5/h4P5AWTcfOF5Dp/+dlUn+K079 4gpbYg2REtagoNI5zc8u+x6U3ktGDuAGjI55G0RiAugj1sfblUNFlP7f/8gyNWBCoznq UD1p0iqSwF2ruaOLHzff9c8ATrvwFdUVkXSpGiYYVt0XU4GL72RI7qL8AwRR/wU6blxP 5A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rmny98vn6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 04:27:21 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3654RKQU008607 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Jul 2023 04:27:20 GMT Received: from [10.217.216.152] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.7; Tue, 4 Jul 2023 21:27:15 -0700 Message-ID: <9f06d400-be7b-6806-b055-8cc7f11db6ca@quicinc.com> Date: Wed, 5 Jul 2023 09:57:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 4/7] clk: qcom: gcc-sc7180: Fix up gcc_sdcc2_apps_clk_src Content-Language: en-US To: David Wronek , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Taniya Das CC: , , , , <~postmarketos/upstreaming@lists.sr.ht>, , map220v References: <20230704163848.169853-2-davidwronek@gmail.com> <20230704163848.169853-6-davidwronek@gmail.com> From: Taniya Das In-Reply-To: <20230704163848.169853-6-davidwronek@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Yss-_JO1LGGMGq4qXZE38ClSYKdjeKti X-Proofpoint-ORIG-GUID: Yss-_JO1LGGMGq4qXZE38ClSYKdjeKti X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-04_16,2023-07-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1011 priorityscore=1501 spamscore=0 impostorscore=0 mlxscore=0 adultscore=0 mlxlogscore=992 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307050039 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 7/4/2023 10:01 PM, David Wronek wrote: > From: map220v > > Add the PARENT_ENABLE flag to prevent the clock from getting stuck at > boot. > > Fixes: 17269568f726 ("clk: qcom: Add Global Clock controller (GCC) driver for SC7180") > Signed-off-by: map220v > Signed-off-by: David Wronek > --- > drivers/clk/qcom/gcc-sc7180.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c > index cef3c77564cf..49f36e1df4fa 100644 > --- a/drivers/clk/qcom/gcc-sc7180.c > +++ b/drivers/clk/qcom/gcc-sc7180.c > @@ -651,6 +651,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .name = "gcc_sdcc2_apps_clk_src", > .parent_data = gcc_parent_data_5, > .num_parents = ARRAY_SIZE(gcc_parent_data_5), > + .flags = CLK_OPS_PARENT_ENABLE, Could you please share what Stuck warnings are you observing? > .ops = &clk_rcg2_floor_ops, > }, > }; -- Thanks & Regards, Taniya Das.