From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH] clk: fix link error for rcar-gen2 To: Arnd Bergmann , Geert Uytterhoeven , Michael Turquette , Stephen Boyd References: <20161021154737.3803065-1-arnd@arndb.de> Cc: Laurent Pinchart , Magnus Damm , Simon Horman , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <9f16dc0d-fe5e-dff8-e461-9e0dfdd23da7@cogentembedded.com> Date: Fri, 21 Oct 2016 19:42:42 +0300 MIME-Version: 1.0 In-Reply-To: <20161021154737.3803065-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed List-ID: Hello. On 10/21/2016 06:47 PM, Arnd Bergmann wrote: > The addition of one more rcar-gen2 based SoC caused a build error (again) > in my randconfig builds: > > arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init': > setup-rcar-gen2.c:(.init.text+0x200): undefined reference to `rcar_gen2_clocks_init' OK, seeing how you got this -- I should have tested the kernel build with only R8A7743 enabled... sorry about that. :-< I probably shouldn't have used rcar_gen2_timer_init() in the 1st place... > I think this has happened twice in the past. Instead of adding each SoC > one at a time, this changes the existing list to always build the > rcar-gen2 related clk files whenever the generic symbol is selected. The problem is we're not going to use this driver on RZ/G SoCs... The newer rcar2-cpg-mssr.c will be used instead -- I submitted the patches for that before ELC-E... > Fixes: 1254f607fc3d ("ARM: shmobile: r8a7743: basic SoC support") > Signed-off-by: Arnd Bergmann [...] MBR, Sergei