From: Stephen Boyd <sboyd@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip clock changes for 6.12 #1
Date: Mon, 09 Sep 2024 14:04:33 -0700 [thread overview]
Message-ID: <9f354ca3eff2c20e98b84bf2590eb586.sboyd@kernel.org> (raw)
In-Reply-To: <2436757.DCRlREXTYf@diego>
Quoting Heiko Stuebner (2024-09-08 14:51:56)
> Hi Mike, Stephen,
>
> please find below a pull-request with some Rockchip clock changes for 6.12
>
> Please pull.
>
In patch 'dt-bindings: clock, reset: Add support for rk3576' (49c04453db81)
WARNING: Block comments should align the * on each line
#100: FILE: include/dt-bindings/clock/rockchip,rk3576-cru.h:3:
+/*
+* Copyright (c) 2023 Rockchip Electronics Co. Ltd.
WARNING: Block comments should align the * on each line
#698: FILE: include/dt-bindings/reset/rockchip,rk3576-cru.h:3:
+/*
+* Copyright (c) 2023 Rockchip Electronics Co. Ltd.
total: 0 errors, 3 warnings, 1212 lines checked
In file included from drivers/clk/rockchip/clk-rk3576.c:14:
drivers/clk/rockchip/clk-rk3576.c:334:7: error: 'mclk_pdm0_p' defined but not used [-Werror=unused-const-variable=]
334 | PNAME(mclk_pdm0_p) = { "mclk_pdm0_src_top", "xin24m" };
| ^~~~~~~~~~~
drivers/clk/rockchip/clk.h:564:43: note: in definition of macro 'PNAME'
564 | #define PNAME(x) static const char *const x[] __initconst
| ^
drivers/clk/rockchip/clk-rk3576.c:333:7: error: 'pdm0_p' defined but not used [-Werror=unused-const-variable=]
333 | PNAME(pdm0_p) = { "clk_pdm0_src_top", "xin24m" };
| ^~~~~~
Please fix these.
prev parent reply other threads:[~2024-09-09 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 21:51 [GIT PULL] Rockchip clock changes for 6.12 #1 Heiko Stuebner
2024-09-09 21:04 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f354ca3eff2c20e98b84bf2590eb586.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox