From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3671F46527 for ; Fri, 15 Dec 2023 20:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jrtc27.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jrtc27.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jrtc27.com header.i=@jrtc27.com header.b="Y10e4GVl" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40c2db2ee28so13100475e9.2 for ; Fri, 15 Dec 2023 12:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jrtc27.com; s=gmail.jrtc27.user; t=1702673290; x=1703278090; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XkbA3FPlNo1r+U6O6Ao4SqV6N3qGQHbqxTmiKmAK7ww=; b=Y10e4GVl5p3c7s5ut1pfDNzZZjIb5zWf7PaoHS89DSdvpe3YC9ndnXZCqvpGo1mghB FwxSotXHXgw9yTiQ50CdGFzQ3MABscjqZdDfQn4Ibyf6Apq5999Eytsz+PzzIEJkj7Nw b+KBqA1Ng7c2lgZirrs9P1pIWOIQEO2rwh/DPz1E4vcDs17RuHedQZvHgVsuj9MbIiCr UUQCXwOPKaHZ79J/7vORmH08rcJcYqQFQgprJb6fev9FGZpxtTcEHWKwdaS5b1AuS8gI mKIMfoMEtqSDKuEOvl4m4gwzQUz9r4Fzfx7VPmUN70tRGrv7wexc6YwMiXg4UQEqDM5T 7/fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702673290; x=1703278090; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XkbA3FPlNo1r+U6O6Ao4SqV6N3qGQHbqxTmiKmAK7ww=; b=w16PaPABNu+txduHbmx7OC7TcdyG5Cowg3r8sbDTWPMC3tOCdEGjdRQzfCkDwuOBGM I4ugiInIkNsrxIkd7x4Up9WFWQLxlrzqj5+RxQ7AU+96smq6NavndonaJi0VWJo8TGAL x7W5AjqREMwYH5JE2U3y2croI6ZJnWRPw0rR9fSFdVBDgNYQ02dyoLWL4GExaIIVzeo5 uYsuzqPEbglqA9dtRPyLVsLFsC89o5BMeK4viAaGuTvJEF5MV9x9VUc0S8NHP/+D07OH 72fxCMCrn4fVSm9lwaVjPFVXShi1VTb8yvFqtgElJIsam4ASEcA3RvB1QrLzrVjYn9JB 7+8w== X-Gm-Message-State: AOJu0Yy4MGGp5rsRVHWUpsvF2zNb1smxdvSqm7d+ANEIhUSnTmHeR7zs OxmPMQpnOjeqSApxnQPxckB8pA== X-Google-Smtp-Source: AGHT+IHmyxYXA7TlsEHSBZ2x2Q3ZtE6ks/hZmTMZ9YZV6t1R+oDgMn/QNCqxM1cqDO/CM4Y9PqXh7w== X-Received: by 2002:a05:600c:808b:b0:40b:5e21:dd24 with SMTP id ew11-20020a05600c808b00b0040b5e21dd24mr6411929wmb.82.1702673290406; Fri, 15 Dec 2023 12:48:10 -0800 (PST) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id p8-20020a05600c358800b0040b40468c98sm31891322wmq.10.2023.12.15.12.48.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Dec 2023 12:48:09 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: [PATCH v3 2/9] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible From: Jessica Clarke In-Reply-To: <20231215204050.2296404-3-cristian.ciocaltea@collabora.com> Date: Fri, 15 Dec 2023 20:47:58 +0000 Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , Michael Turquette , Stephen Boyd , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Giuseppe Cavallaro , netdev@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-riscv , linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20231215204050.2296404-1-cristian.ciocaltea@collabora.com> <20231215204050.2296404-3-cristian.ciocaltea@collabora.com> To: Cristian Ciocaltea X-Mailer: Apple Mail (2.3774.200.91.1.1) On 15 Dec 2023, at 20:40, Cristian Ciocaltea = wrote: >=20 > The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly > similar to the newer JH7110, but it requires only two interrupts and a > single reset line, which is 'ahb' instead of the commonly used > 'stmmaceth'. >=20 > Since the common binding 'snps,dwmac' allows selecting 'ahb' only in > conjunction with 'stmmaceth', extend the logic to also permit = exclusive > usage of the 'ahb' reset name. This ensures the following use cases = are > supported: >=20 > JH7110: reset-names =3D "stmmaceth", "ahb"; > JH7100: reset-names =3D "ahb"; > other: reset-names =3D "stmmaceth"; >=20 > Also note the need to use a different dwmac fallback, as v5.20 applies > to JH7110 only, while JH7100 relies on v3.7x. >=20 > Signed-off-by: Cristian Ciocaltea > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 3 +- > .../bindings/net/starfive,jh7110-dwmac.yaml | 74 +++++++++++++------ > 2 files changed, 55 insertions(+), 22 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml = b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 5c2769dc689a..c1380ff1c054 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -95,6 +95,7 @@ properties: > - snps,dwmac-5.20 > - snps,dwxgmac > - snps,dwxgmac-2.10 > + - starfive,jh7100-dwmac > - starfive,jh7110-dwmac >=20 > reg: > @@ -146,7 +147,7 @@ properties: > reset-names: > minItems: 1 > items: > - - const: stmmaceth > + - enum: [stmmaceth, ahb] > - const: ahb I=E2=80=99m not so well-versed in the YAML bindings, but would this not = allow reset-names =3D "ahb", "ahb"? Jess