public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Rayyan Ansari" <rayyan@ansari.sh>, <linux-arm-msm@vger.kernel.org>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] clk: qcom: smd: Add XO RPM clocks for MSM8226/MSM8974
Date: Fri, 20 Jan 2023 16:19:57 +0100	[thread overview]
Message-ID: <CPX4AK05WU5V.2XZ2KT3M3ZHA@otso> (raw)
In-Reply-To: <20230119190534.317041-2-rayyan@ansari.sh>

On Thu Jan 19, 2023 at 8:05 PM CET, Rayyan Ansari wrote:
> Add the XO and XO_A clocks to the MSM8974 clock list, which is also
> used on MSM8226.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
>  drivers/clk/qcom/clk-smd-rpm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index fea505876855..42ea3bb37f63 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -549,6 +549,8 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8974, cxo_a1_pin, cxo_a1_a_pin, 5, 19200
>  DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8974, cxo_a2_pin, cxo_a2_a_pin, 6, 19200000);
>  
>  static struct clk_smd_rpm *msm8974_clks[] = {
> +	[RPM_SMD_XO_CLK_SRC] 		= &sdm660_bi_tcxo,
> +	[RPM_SMD_XO_A_CLK_SRC] 		= &sdm660_bi_tcxo_a,

Hi Rayyan,

This doesn't apply on linux-next.
The references were renamed to clk_smd_rpm_branch_bi_tcxo*
Please rebase.

Regards
Luca

>  	[RPM_SMD_PNOC_CLK]		= &msm8916_pcnoc_clk,
>  	[RPM_SMD_PNOC_A_CLK]		= &msm8916_pcnoc_a_clk,
>  	[RPM_SMD_SNOC_CLK]		= &msm8916_snoc_clk,
> -- 
> 2.39.0


      parent reply	other threads:[~2023-01-20 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 19:05 [PATCH v2 0/2] Add XO clocks for MSM8226 Rayyan Ansari
2023-01-19 19:05 ` [PATCH v2 1/2] clk: qcom: smd: Add XO RPM clocks for MSM8226/MSM8974 Rayyan Ansari
2023-01-19 19:10   ` Konrad Dybcio
2023-01-20 15:19   ` Luca Weiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CPX4AK05WU5V.2XZ2KT3M3ZHA@otso \
    --to=luca.weiss@fairphone.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rayyan@ansari.sh \
    --cc=sboyd@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox