Re: [PATCH 1/5] dt-bindings: clock: qcom,gpucc: Fix SM6350 clock names

Krzysztof Kozlowski
2023-03-17T08:38:11Z

On 16/03/2023 12:16, Konrad Dybcio wrote:
> SM6350 GPUCC uses the same clock names as the rest of the gang, except
> without a _src suffix. Account for that.

Why not fixing the names instead (to use the same)? If the clocks are
the same, why using different names for the inputs? To remind - these
are not names of clocks in GCC, but names of clock inputs to the device.

>
> Fixes: 7b91b9d8cc6c ("dt-bindings: clock: add SM6350 QCOM Graphics clock bindings")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../devicetree/bindings/clock/qcom,gpucc.yaml | 29 +++++++++++++++++++---
> 1 file changed, 25 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> index db53eb288995..d209060a619d 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> @@ -43,10 +43,8 @@ properties:
> - description: GPLL0 div branch source
>
> clock-names:
> - items:
> - - const: bi_tcxo
> - - const: gcc_gpu_gpll0_clk_src
> - - const: gcc_gpu_gpll0_div_clk_src
> + minItems: 3

Drop minItems, not needed as it is implied by maxItems.

> + maxItems: 3
>
> '#clock-cells':
> const: 1
> @@ -71,6 +69,29 @@ required:
>
> additionalProperties: false
>
>

Best regards,
Krzysztof