Re: [PATCH v3 5/7] clk: eyeq: use the auxiliary device creation helper

Théo Lebrun
2025-02-12T14:51:38Z

Hello Jerome,

On Tue Feb 11, 2025 at 6:28 PM CET, Jerome Brunet wrote:
> The auxiliary device creation of this driver is simple enough to
> use the available auxiliary device creation helper.
>
> Use it and remove some boilerplate code.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Tested the series, it works. However:
- The newly introduced helper does a
device_set_of_node_from_dev(child_device, parent_device) call which
used to be done by our reset-eyeq child.
- reset-eyeq also did a WARN_ON(dev->of_node) to validate it didn't
have an OF node at probe (checking its assumptions).
- We can remove both. See patch that got sent as a reply.

With that additional patch:

Tested-by: Théo Lebrun <theo.lebrun@bootlin.com> # On Mobileye EyeQ5

Note: Philipp Zabel has been CCed on the patch and this email as the
reset maintainer.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering