Re: [PATCH 2/6] clk: qcom: camcc-sm6350: Specify Titan GDSC power domain as a parent to other

["Luca Weiss" <luca.weiss@fairphone.com>]

Hi Vladimir,

On Thu Sep 11, 2025 at 3:12 AM CEST, Vladimir Zapolskiy wrote:
> Make Titan GDSC power domain as a parent of all other GDSC power domains
> provided by the SM6350 camera clock controller to enforce a correct
> sequence of enabling and disabling power domains by the consumers.

Thanks, I've had something like this in my camera branch for a while,
but since I've had enough other problems with clocks/PDs there or camss
not working fully yet, I haven't bothered to upstream it.

Thanks!

Regards
Luca

>
> Fixes: 80f5451d9a7c ("clk: qcom: Add camera clock controller driver for SM6350")
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  drivers/clk/qcom/camcc-sm6350.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-sm6350.c
> index 8aac97d29ce3..6c272f7b0721 100644
> --- a/drivers/clk/qcom/camcc-sm6350.c
> +++ b/drivers/clk/qcom/camcc-sm6350.c
> @@ -1693,6 +1693,8 @@ static struct clk_branch camcc_sys_tmr_clk = {
>  	},
>  };
>  
> +static struct gdsc titan_top_gdsc;
> +
>  static struct gdsc bps_gdsc = {
>  	.gdscr = 0x6004,
>  	.en_rest_wait_val = 0x2,
> @@ -1702,6 +1704,7 @@ static struct gdsc bps_gdsc = {
>  		.name = "bps_gdsc",
>  	},
>  	.pwrsts = PWRSTS_OFF_ON,
> +	.parent = &titan_top_gdsc.pd,
>  	.flags = VOTABLE,
>  };
>  
> @@ -1714,6 +1717,7 @@ static struct gdsc ipe_0_gdsc = {
>  		.name = "ipe_0_gdsc",
>  	},
>  	.pwrsts = PWRSTS_OFF_ON,
> +	.parent = &titan_top_gdsc.pd,
>  	.flags = VOTABLE,
>  };
>  
> @@ -1726,6 +1730,7 @@ static struct gdsc ife_0_gdsc = {
>  		.name = "ife_0_gdsc",
>  	},
>  	.pwrsts = PWRSTS_OFF_ON,
> +	.parent = &titan_top_gdsc.pd,
>  };
>  
>  static struct gdsc ife_1_gdsc = {
> @@ -1737,6 +1742,7 @@ static struct gdsc ife_1_gdsc = {
>  		.name = "ife_1_gdsc",
>  	},
>  	.pwrsts = PWRSTS_OFF_ON,
> +	.parent = &titan_top_gdsc.pd,
>  };
>  
>  static struct gdsc ife_2_gdsc = {
> @@ -1748,6 +1754,7 @@ static struct gdsc ife_2_gdsc = {
>  		.name = "ife_2_gdsc",
>  	},
>  	.pwrsts = PWRSTS_OFF_ON,
> +	.parent = &titan_top_gdsc.pd,
>  };
>  
>  static struct gdsc titan_top_gdsc = {