Re: [PATCH v4 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper

["Théo Lebrun" <theo.lebrun@bootlin.com>]

On Mon Dec 15, 2025 at 4:11 PM CET, Luca Ceresoli wrote:
> On Mon Dec 15, 2025 at 4:08 PM CET, Théo Lebrun wrote:
>> On Wed Dec 10, 2025 at 5:06 PM CET, Luca Ceresoli wrote:
>>> On Mon Nov 24, 2025 at 3:41 PM CET, Théo Lebrun wrote:
>>>> +	provider = devm_of_phy_provider_register(dev, eq5_phy_xlate);
>>>> +	if (IS_ERR(provider)) {
>>>> +		dev_err(dev, "registering provider failed\n");
>>>> +		return PTR_ERR(provider);
>>>> +	}
>>>
>>> As above, why not dev_err_probe()?
>>
>> Good idea once again.
>>
>>> Other than the above minor issues, LGTM. This driver looks cleanly
>>> implemented.
>>
>> Thanks for the review. Does that imply I can append your Rb trailer?
>
> If you apply all the changes I have mention, yes, but in doubt you can
> avoid it and I'll review your next version. Re-reviewing is much faster
> than reviewing the first time (last famous words).

I've taken the Rb trailer, hoping everything is to your taste.

https://lore.kernel.org/lkml/20251215-macb-phy-v5-0-a9dfea39da34@bootlin.com/

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com