* Re: [PATCH] rust: use consistent backtick formatting for NULL in docs
[not found] ` <DEMK8K1I3FFY.27ERA2LKI7MYB@nvidia.com>
@ 2026-01-18 22:14 ` Miguel Ojeda
2026-01-18 23:07 ` Danilo Krummrich
0 siblings, 1 reply; 2+ messages in thread
From: Miguel Ojeda @ 2026-01-18 22:14 UTC (permalink / raw)
To: Alexandre Courbot, Michael Turquette, Stephen Boyd,
Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
Brendan Higgins, David Gow, Rae Moar
Cc: Peter Novak, ojeda, rust-for-linux, linux-clk,
open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross
On Mon, Dec 1, 2025 at 4:29 AM Alexandre Courbot <acourbot@nvidia.com> wrote:
>
> On Mon Dec 1, 2025 at 6:12 AM JST, Peter Novak wrote:
> > Some doc comments use `NULL` while others use plain NULL.
> > This patch makes it consistent by adding backticks everywhere,
> > matching the majority of existing usage.
> >
> > This is my first kernel patch - just getting familiar with
> > the contribution process.
> >
> > Signed-off-by: Peter Novak <seimun018r@gmail.com>
>
> This looks like a pretty good first patch! :)
>
> Just make sure to put the meta-comments (the "This is my first kernel
> patch" sentence) below a `---` line so they don't get picked up in the
> git log. See [1] for an example.
>
> With that sentence removed (which I believe will be done when applying
> if no other fixes are required),
>
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>
> I have double-checked with `rg '\/\/\/.*NULL'` from the `rust` directory
> and this indeed appears to address all cases.
>
> [1] https://lore.kernel.org/rust-for-linux/20251124-bounded_fix-v1-1-d8e34e1c727f@nvidia.com/
Thanks Alexandre for this welcoming review, and Peter for the patch.
I see Cc's were missing, which explains why there weren't more
reactions. OK, added everyone now: clk, debugfs and KUnit.
It would be nice to have Acked-by's for them, but if nobody shouts, I
guess I will eventually apply it...
Thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rust: use consistent backtick formatting for NULL in docs
2026-01-18 22:14 ` [PATCH] rust: use consistent backtick formatting for NULL in docs Miguel Ojeda
@ 2026-01-18 23:07 ` Danilo Krummrich
0 siblings, 0 replies; 2+ messages in thread
From: Danilo Krummrich @ 2026-01-18 23:07 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alexandre Courbot, Michael Turquette, Stephen Boyd,
Greg Kroah-Hartman, Rafael J. Wysocki, Brendan Higgins, David Gow,
Rae Moar, Peter Novak, ojeda, rust-for-linux, linux-clk,
open list:KERNEL SELFTEST FRAMEWORK, KUnit Development,
Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross
On Sun Jan 18, 2026 at 11:14 PM CET, Miguel Ojeda wrote:
> It would be nice to have Acked-by's for them
Acked-by: Danilo Krummrich <dakr@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-18 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251130211233.367946-1-seimun018r@gmail.com>
[not found] ` <DEMK8K1I3FFY.27ERA2LKI7MYB@nvidia.com>
2026-01-18 22:14 ` [PATCH] rust: use consistent backtick formatting for NULL in docs Miguel Ojeda
2026-01-18 23:07 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox