Linux clock framework development
 help / color / mirror / Atom feed
From: Shiji Yang <yangshiji66@outlook.com>
To: sergio.paracuellos@gmail.com
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	tsbogend@alpha.franken.de
Subject: Re: [PATCH] clk: ralink: mtmips: fix clock plan for Ralink SoC RT3883
Date: Mon,  9 Sep 2024 19:17:34 +0800	[thread overview]
Message-ID: <TYAP286MB07463A0C8ABD8837888C6853BC992@TYAP286MB0746.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240806142902.224164-1-sergio.paracuellos@gmail.com>

On Tue,  6 Aug 2024 16:29:02 +0200, Sergio Paracuellos wrote:

>diff --git a/drivers/clk/ralink/clk-mtmips.c b/drivers/clk/ralink/clk-mtmips.c
>index 50a443bf79ec..787ff3e66b34 100644
>--- a/drivers/clk/ralink/clk-mtmips.c
>+++ b/drivers/clk/ralink/clk-mtmips.c
>@@ -267,6 +267,11 @@ static struct mtmips_clk_fixed rt305x_fixed_clocks[] = {
> 	CLK_FIXED("xtal", NULL, 40000000)
> };
> 
>+static struct mtmips_clk_fixed rt3383_fixed_clocks[] = {

Hi! I found a small issue. The SoC name is rt3883 instead of rt3383.

>+	CLK_FIXED("xtal", NULL, 40000000),
>+	CLK_FIXED("periph", "xtal", 40000000)
>+};
>+
> static struct mtmips_clk_fixed rt3352_fixed_clocks[] = {
> 	CLK_FIXED("periph", "xtal", 40000000)
> };
>@@ -779,8 +784,8 @@ static const struct mtmips_clk_data rt3352_clk_data = {
> static const struct mtmips_clk_data rt3883_clk_data = {
> 	.clk_base = rt3883_clks_base,
> 	.num_clk_base = ARRAY_SIZE(rt3883_clks_base),
>-	.clk_fixed = rt305x_fixed_clocks,
>-	.num_clk_fixed = ARRAY_SIZE(rt305x_fixed_clocks),
>+	.clk_fixed = rt3383_fixed_clocks,
>+	.num_clk_fixed = ARRAY_SIZE(rt3383_fixed_clocks),
> 	.clk_factor = NULL,
> 	.num_clk_factor = 0,
> 	.clk_periph = rt5350_pherip_clks,

Regards,
Shiji Yang

  parent reply	other threads:[~2024-09-09 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 14:29 [PATCH] clk: ralink: mtmips: fix clock plan for Ralink SoC RT3883 Sergio Paracuellos
2024-09-02  9:49 ` Sergio Paracuellos
2024-09-09 11:17 ` Shiji Yang [this message]
2024-09-10  4:14   ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAP286MB07463A0C8ABD8837888C6853BC992@TYAP286MB0746.JPNP286.PROD.OUTLOOK.COM \
    --to=yangshiji66@outlook.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox