Re: [PATCH] clk: qcom: gdsc: Remove direct runtime PM calls

Johan Hovold
2022-11-04T10:54:16Z

On Thu, Nov 03, 2022 at 11:19:08AM -0700, Stephen Boyd wrote:
> Quoting Johan Hovold (2022-11-03 06:21:33)
> > On Wed, Nov 02, 2022 at 09:53:49AM -0700, Stephen Boyd wrote:
> > > Quoting Johan Hovold (2022-11-02 03:52:39)
> >
> > > > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > > > Cc: Johan Hovold <johan+linaro@kernel.org>
> > > > > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > > > > Cc: Taniya Das <quic_tdas@quicinc.com>
> > > > > Cc: Satya Priya <quic_c_skakit@quicinc.com>
> > > > > Cc: Douglas Anderson <dianders@chromium.org>
> > > > > Cc: Matthias Kaehlcke <mka@chromium.org>
> > > > > Reported-by: Stephen Boyd <swboyd@chromium.org>
> > > >
> > > > We typically don't add Reported-by tags for bugs we find and fix
> > > > ourselves.
> > >
> > > Heh, I didn't see anything like that in Documentation/ so it seems fine.
> > > I debugged my problem and reported it.
> >
> > I'd say the documentation is pretty clear on this matter:
> >
> > Reported-by: names a user who reported a problem which is fixed by this
> > patch; this tag is used to give credit to the (often underappreciated)
> > people who test our code and let us know when things do not work
> > correctly.
> >
> > - Documentation/process/5.Posting.rst
> >
> > The Reported-by tag gives credit to people who find bugs and report
> > them and it hopefully inspires them to help us again in the future.
> > Please note that if the bug was reported in private, then ask for
> > permission first before using the Reported-by tag.
> >
> > - Documentation/process/submitting-patches.rst
>
> I don't see anything above that says I can't add this tag if I reported
> (by sending an email about the problem to the list), debugged, and
> solved the problem by sending a patch.

We don't try to prevent every strange interpretation of our docs by
spelling everything out. Just look at why we added a tag in the first
place and how it *is* being using.

> > Just like you don't add a Tested-by tag for every patch you submit, it
> > is implied that you found the issue you fix unless you explicitly
> > attribute that to a third party using Reported-by.
>
> I don't see how this is the same. It certainly is not explicit, as you
> say.

We added the Reported-by tag so that users reporting bugs would get some
credit and not just the person fixing the bug. Just as we did for
Tested-by.

If some author added a Tested-by tag for themselves to their own patches
I'm sure you'd call that out too as that's not the way the tag is meant
to be used.

The reasoning is exactly the same for Reported-by.

> I wouldn't have added the tag if I didn't send an email to the list with
> the lockdep splat and follow that up with a bisection report for
> suspend/resume being broken. Shouldn't we value those sorts of bug
> report emails? I will add a link to the report in the commit text to
> clarify.

Ok, perhaps that would make this a bit more reasonable (Reported-by +
Link to report), but I still do not think the tag is warranted.

> > This is the first time I see anyone trying to use Reported-by this way,
> > and even if you think the documentation isn't clear enough on this, our
> > praxis is.
> >
>
> Ok, so is it just a shock to see this for the first time? What is the
> problem with the tag? Can you elaborate on your concerns? I would like
> to understand.

It's apparently the first time you try to give credit to yourself for
finding a bug this way too, so let's turn that question around. Why do
you suddenly insist on crediting yourself this way when no one else does
so?

In the end it's about maintaining a common interpretation of these tags
and avoiding unnecessary noise. I'm sure no one wants to see a redundant
Tested-by tag on every commit nor a redundant Reported-by tag on every
bug fix for bugs that kernel developers find themselves. And if only
some people start using the tags this way it would also skew our
statistics (e.g. the LWN reports).

Johan