From: Mark Brown <broonie@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Daniel Vetter" <daniel@ffwll.ch>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Abel Vesa" <abelvesa@kernel.org>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Samuel Holland" <samuel@sholland.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Vinod Koul" <vkoul@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sekhar Nori" <nsekhar@ti.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Takashi Iwai" <tiwai@suse.com>,
"David Airlie" <airlied@gmail.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"David Lechner" <david@lechnology.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-stm32@st-md-mailman.stormreply.com,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, linux-mips@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-actions@lists.infradead.org, linux-clk@vger.kernel.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
patches@opensource.cirrus.com, linux-tegra@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook
Date: Fri, 4 Nov 2022 15:59:53 +0000 [thread overview]
Message-ID: <Y2U2+ePwRieYkNjv@sirena.org.uk> (raw)
In-Reply-To: <20221104155123.qomguvthehnogkdd@houat>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On Fri, Nov 04, 2022 at 04:51:23PM +0100, Maxime Ripard wrote:
> Just filling determine_rate if it's missing with
> __clk_mux_determine_rate will possibly pick different parents, and I'm
> fairly certain that this have never been tested on most platforms, and
> will be completely broken. And I don't really want to play a game of
> whack-a-mole adding that flag everywhere it turns out it's broken.
Well, hopefully everyone for whom it's an issue currently will be
objecting to this version of the change anyway so we'll either know
where to set the flag or we'll get the whack-a-mole with the series
being merged?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-11-04 16:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221018-clk-range-checks-fixes-v2-0-f6736dec138e@cerno.tech>
[not found] ` <20221018-clk-range-checks-fixes-v2-56-f6736dec138e@cerno.tech>
2022-11-04 14:31 ` [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate Paul Cercueil
2022-11-04 14:59 ` Maxime Ripard
2022-11-04 17:35 ` Aidan MacDonald
2022-11-07 8:54 ` Maxime Ripard
2022-11-07 20:57 ` Aidan MacDonald
2022-11-09 11:00 ` Maxime Ripard
[not found] ` <06a293adc75990ed3e297b076fc38d8a.sboyd@kernel.org>
2023-03-23 15:35 ` Aidan MacDonald
2023-03-24 11:19 ` Maxime Ripard
2023-03-24 20:58 ` Aidan MacDonald
2023-03-27 19:24 ` Maxime Ripard
2023-04-05 12:57 ` Paul Cercueil
2023-04-05 14:50 ` Maxime Ripard
2023-04-05 15:29 ` Paul Cercueil
2022-11-05 10:33 ` Paul Cercueil
2022-11-09 10:53 ` Maxime Ripard
2022-11-09 11:36 ` Paul Cercueil
[not found] ` <20221018-clk-range-checks-fixes-v2-43-f6736dec138e@cerno.tech>
2022-11-04 15:44 ` [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook Mark Brown
2022-11-04 15:51 ` Maxime Ripard
2022-11-04 15:59 ` Mark Brown [this message]
2022-11-07 8:43 ` Maxime Ripard
2022-11-07 12:06 ` Mark Brown
2022-11-07 15:26 ` Maxime Ripard
2022-11-07 16:02 ` Mark Brown
[not found] ` <5819b1362f35ce306e1b6d566bfd44e5.sboyd@kernel.org>
2023-03-29 19:50 ` Maxime Ripard
[not found] ` <20221018-clk-range-checks-fixes-v2-21-f6736dec138e@cerno.tech>
2022-11-04 16:45 ` [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: " David Lechner
2022-11-07 12:06 ` Maxime Ripard
2022-11-07 14:52 ` David Lechner
[not found] ` <20221018-clk-range-checks-fixes-v2-22-f6736dec138e@cerno.tech>
2022-11-04 16:46 ` [PATCH v2 22/65] " David Lechner
[not found] ` <20221018-clk-range-checks-fixes-v2-54-f6736dec138e@cerno.tech>
2022-11-04 16:49 ` [PATCH v2 54/65] clk: da8xx: clk48: Switch to determine_rate David Lechner
2022-11-07 14:52 ` Maxime Ripard
[not found] ` <20221018-clk-range-checks-fixes-v2-42-f6736dec138e@cerno.tech>
2022-11-05 3:45 ` [PATCH v2 42/65] rtc: sun6i: Add a determine_rate hook Samuel Holland
[not found] ` <20221018-clk-range-checks-fixes-v2-28-f6736dec138e@cerno.tech>
2022-11-07 7:51 ` [PATCH v2 28/65] clk: renesas: r9a06g032: " Geert Uytterhoeven
[not found] ` <20221018-clk-range-checks-fixes-v2-65-f6736dec138e@cerno.tech>
2022-11-07 10:56 ` [PATCH v2 65/65] clk: Warn if we register a mux without determine_rate Charles Keepax
[not found] ` <20221018-clk-range-checks-fixes-v2-20-f6736dec138e@cerno.tech>
2022-11-07 10:58 ` [PATCH v2 20/65] clk: wm831x: clkout: Add a determine_rate hook Charles Keepax
[not found] ` <20221018-clk-range-checks-fixes-v2-34-f6736dec138e@cerno.tech>
2022-11-08 13:25 ` [PATCH v2 34/65] clk: ux500: prcmu: " Linus Walleij
2022-11-09 11:05 ` Maxime Ripard
[not found] ` <20221018-clk-range-checks-fixes-v2-58-f6736dec138e@cerno.tech>
2022-11-09 2:43 ` [PATCH v2 58/65] clk: sprd: composite: Switch to determine_rate Chunyan Zhang
[not found] ` <20221018-clk-range-checks-fixes-v2-35-f6736dec138e@cerno.tech>
2022-11-08 13:27 ` [PATCH v2 35/65] clk: ux500: sysctrl: Add a determine_rate hook Linus Walleij
2022-11-10 11:28 ` Ulf Hansson
2022-11-10 11:39 ` Linus Walleij
2022-11-10 13:05 ` Ulf Hansson
2022-11-11 9:20 ` Linus Walleij
2022-11-14 9:05 ` Lee Jones
[not found] ` <20221018-clk-range-checks-fixes-v2-13-f6736dec138e@cerno.tech>
2022-11-13 22:35 ` [PATCH v2 13/65] clk: lmk04832: clkout: " Liam Beguin
[not found] ` <f804380a14c346fdbbf3286bcb40b3c2.sboyd@kernel.org>
2023-03-22 10:01 ` [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2U2+ePwRieYkNjv@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=abelvesa@kernel.org \
--cc=afaerber@suse.de \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=dinguyen@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jcmvbkbc@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=paul@crapouillou.net \
--cc=pdeschrijver@nvidia.com \
--cc=perex@perex.cz \
--cc=pgaikwad@nvidia.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox