Re: [PATCH v8 3/4] clk: qcom: rpmh: Add support for SM8550 rpmh clocks

Dmitry Baryshkov
2023-01-04T14:40:45Z

On 04/01/2023 14:45, Abel Vesa wrote:
> On 23-01-04 12:46:55, Dmitry Baryshkov wrote:
>> On 04/01/2023 11:34, Abel Vesa wrote:
>>> Adds the RPMH clocks present in SM8550 SoC.
>>>
>>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>> drivers/clk/qcom/clk-rpmh.c | 36 ++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 36 insertions(+)
>>
>> I think the plan was to have the _PAD clock as a child node of the rpmcc. Is
>> it still the planned implementation?
>
> Yes. Here is how the dts rpmhcc node will look like:
>
> rpmhcc: clock-controller {
> compatible = "qcom,sm8550-rpmh-clk";
> #clock-cells = <1>;
> clock-names = "xo";
> clocks = <&xo_board>;
>
> bi_tcxo_div2: bi-tcxo-div2-clk {
> #clock-cells = <0>;
> compatible = "fixed-factor-clock";
> clocks = <&rpmhcc RPMH_CXO_CLK>;
> clock-mult = <1>;
> clock-div = <2>;
> };
>
> bi_tcxo_ao_div2: bi-tcxo-div2-ao-clk {
> #clock-cells = <0>;
> compatible = "fixed-factor-clock";
> clocks = <&rpmhcc RPMH_CXO_CLK_A>;
> clock-mult = <1>;
> clock-div = <2>;
> };
> };

Does this snippet pass bindings validation?

>
> The clock nodes will be probed on of_clk_init.

Ah, I see. of_clk_init() will initialize clocks even if the parent
device is not fully probed. Thank you for the explanation!

--
With best wishes
Dmitry