From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94E4C49EA7 for ; Mon, 28 Jun 2021 05:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC5E161C51 for ; Mon, 28 Jun 2021 05:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232129AbhF1Foq (ORCPT ); Mon, 28 Jun 2021 01:44:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:59048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232132AbhF1Foq (ORCPT ); Mon, 28 Jun 2021 01:44:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B02A61C17; Mon, 28 Jun 2021 05:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624858941; bh=8kPsxiKplIOG09PMS3o+imfXElGS2OAMUTIFSFHl+bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JZfEtWKPjkYgMZ782UBxpDRZlxYzzttgNA0UB/9kRluRXTKWkRiNKM7uiNxJ1plVT oTwVczFMi3LCRB4obGsID7LVHRh91dG+nSoSeUnrh8CNirqP2fUykRUYx7AE4rioze OKpTKrbWRoIfM/7I0NJNQFHy9vrUUB800k9n5rcKbxSeBr3PDUXHLp3hL8eU9bmGqf SsfX+HY4712dlylqiRFLd9RQKF4Tq8NS82lhNjcTbtdyriAPYQZiOVi3Hib5h/HF51 e0khV/aOYhN+AU8KDHwLyYXB3LSBJadLvI66z30jls4wd9KAlv7/NLRnYuOHhpJSoz xde4A/PoZGHCg== Date: Mon, 28 Jun 2021 11:12:17 +0530 From: Vinod Koul To: Bjorn Andersson Cc: Andy Gross , Michael Turquette , Stephen Boyd , dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] clk: qcom: gdsc: Ensure regulator init state matches GDSC state Message-ID: References: <20210625225414.1318338-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625225414.1318338-1-bjorn.andersson@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 25-06-21, 15:54, Bjorn Andersson wrote: > As GDSCs are registered and found to be already enabled > gdsc_toggle_logic() will be invoked for votable GDSCs and ensure that > the vote is matching the hardware state. Part of this the related > regulator will be enabled. > > But for non-votable GDSCs the regulator and GDSC status will be out of > sync and as the GDSC is later disabled regulator_disable() will face an > unbalanced enable-count, or something might turn off the supply under > the feet of the GDSC. > > So ensure that the regulator is enabled even for non-votable GDSCs. Reviewed-by: Vinod Koul -- ~Vinod