public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, rdunlap@infradead.org, ping.bai@nxp.com,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK
Date: Wed, 6 Oct 2021 22:21:50 +0300	[thread overview]
Message-ID: <YV33TgGoZMw6Ae5y@ryzen> (raw)
In-Reply-To: <20211006190008.1935051-1-festevam@gmail.com>

On 21-10-06 16:00:08, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
> 
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
> 
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
> 
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied with Randy's ack and my R-b tag. Thanks.

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
>  config CLK_IMX8ULP
>  	tristate "IMX8ULP CCM Clock Driver"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	select MXC_CLK
>  	help
>  	    Build the driver for i.MX8ULP CCM Clock Driver
> -- 
> 2.25.1
> 

      parent reply	other threads:[~2021-10-06 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 19:00 [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK Fabio Estevam
2021-10-06 19:13 ` Randy Dunlap
2021-10-06 19:15 ` Abel Vesa
2021-10-06 19:21 ` Abel Vesa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YV33TgGoZMw6Ae5y@ryzen \
    --to=abel.vesa@nxp.com \
    --cc=festevam@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=rdunlap@infradead.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox