Re: [PATCH 3/8] soc: renesas: rzn1-sysc: Export function to set dmamux

kernel test robot
2022-02-20T18:16:53Z

Hi Miquel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on geert-renesas-devel/next]
[also build test WARNING on geert-renesas-drivers/renesas-clk robh/for-next linus/master v5.17-rc4 next-20220217]
[cannot apply to vkoul-dmaengine/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Miquel-Raynal/RZN1-DMA-support/20220220-182519
base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next
config: arc-randconfig-r043-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210247.Ul5J6pwr-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ed9b880ea7f2b23b42feeed7a6ed898cd09ae2f1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Miquel-Raynal/RZN1-DMA-support/20220220-182519
git checkout ed9b880ea7f2b23b42feeed7a6ed898cd09ae2f1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/clk/renesas/ drivers/mtd/spi-nor/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/clk/renesas/r9a06g032-clocks.c:320:5: warning: no previous prototype for 'r9a06g032_syscon_set_dmamux' [-Wmissing-prototypes]
320 | int r9a06g032_syscon_set_dmamux(u32 mask, u32 val)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/r9a06g032_syscon_set_dmamux +320 drivers/clk/renesas/r9a06g032-clocks.c

317
318 /* Exported helper to access the DMAMUX register */
319 static struct r9a06g032_priv *syscon_priv;
> 320 int r9a06g032_syscon_set_dmamux(u32 mask, u32 val)
321 {
322 u32 dmamux;
323
324 if (!syscon_priv)
325 return -EPROBE_DEFER;
326
327 spin_lock(&syscon_priv->lock);
328
329 dmamux = readl(syscon_priv->reg + R9A06G032_SYSCON_DMAMUX);
330 dmamux &= ~mask;
331 dmamux |= val & mask;
332 writel(dmamux, syscon_priv->reg + R9A06G032_SYSCON_DMAMUX);
333
334 spin_unlock(&syscon_priv->lock);
335
336 return 0;
337 }
338

---
0-DAY CI Kernel Test Service, Intel Corporation