Re: [PATCH v2 7/7] clk: qcom: add camera clock controller driver for SM8450 SoC

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Mon 14 Mar 06:42 CDT 2022, Vladimir Zapolskiy wrote:
> diff --git a/drivers/clk/qcom/camcc-sm8450.c b/drivers/clk/qcom/camcc-sm8450.c
[..]
> +static struct pll_vco lucid_evo_vco[] = {

const

> +	{ 249600000, 2000000000, 0 },
> +};
> +
> +static struct pll_vco rivian_evo_vco[] = {

const

> +	{ 864000000, 1056000000, 0 },
> +};
> +
> +static const struct alpha_pll_config cam_cc_pll0_config = {
> +	.l = 0x3E,

Please use lowercase hex digits throughout the patch.

> +	.alpha = 0x8000,
> +	.config_ctl_val = 0x20485699,
> +	.config_ctl_hi_val = 0x00182261,
> +	.config_ctl_hi1_val = 0x32AA299C,
> +	.user_ctl_val = 0x00008400,
> +	.user_ctl_hi_val = 0x00000805,
> +};
> +
[..]
> +static struct platform_driver cam_cc_sm8450_driver = {
> +	.probe = cam_cc_sm8450_probe,
> +	.driver = {
> +		.name = "cam_cc-sm8450",
> +		.of_match_table = cam_cc_sm8450_match_table,
> +	},
> +};
> +
> +static int __init cam_cc_sm8450_init(void)
> +{
> +	return platform_driver_register(&cam_cc_sm8450_driver);
> +}
> +subsys_initcall(cam_cc_sm8450_init);

Camera isn't critical to boot the system, so I think you can replace
this with just module_platform_driver(cam_cc_sm8450_driver);

Rest looks good to me.

Thanks,
Bjorn

> +
> +static void __exit cam_cc_sm8450_exit(void)
> +{
> +	platform_driver_unregister(&cam_cc_sm8450_driver);
> +}
> +module_exit(cam_cc_sm8450_exit);
> +
> +MODULE_DESCRIPTION("QTI CAMCC SM8450 Driver");
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.33.0
>