From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB015C433F5 for ; Thu, 14 Apr 2022 16:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241427AbiDNQHC (ORCPT ); Thu, 14 Apr 2022 12:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348944AbiDNPkM (ORCPT ); Thu, 14 Apr 2022 11:40:12 -0400 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9BFBC5583; Thu, 14 Apr 2022 08:19:00 -0700 (PDT) Received: by mail-oi1-f182.google.com with SMTP id 12so5699020oix.12; Thu, 14 Apr 2022 08:19:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rTnbii0TkfiP0IgylH+LPQeyfK4chNSMZIeQMu2dlZ0=; b=44Lvk3aKbxtOBzPkD6hHm1CjWoWpgA2QoNMfqHRlgXnizhX3EsCyxHVnWDrEIuFXZm OKSKF4h0xAwKNpzt8GbSoFbgZsmTbNDz1GtOV5S0ZkB8M6fFedYV8Yz1LTp4NzMNlmml xLJz1eR0hN8/+MRc9t087Y/+QNhiOgMIcu5YLWG8cbXEiAuZyW8Ppp1zRBKBwRvjQ1MK 0Jsf1Uj/PGGIz/+qgviNF3h9+NwbCYm7YkPEWVCnDNuA9oGJ/maWtdjJWYj7LG2wQlNb WDaNDTnh3Jr4cjrm68uhWtIzKOxNPXp0zM+QPN45OyFobk68bnRaT3N6NATyVEBQPWmi cG1A== X-Gm-Message-State: AOAM5337BI4i00pmA/TgLak4RiYeZCtyuB0uTv8alrQdJGGz8JsgKKAy sPCyM5TH9XBS6myCBshuMg== X-Google-Smtp-Source: ABdhPJx97/FQcjk9Be6OMKujrhUC85sEPYMS6H5cAeRSjdGYelkOgG068e0xOR/WfxQnx5K/o4EfsQ== X-Received: by 2002:aca:2418:0:b0:2ee:f7da:795f with SMTP id n24-20020aca2418000000b002eef7da795fmr1833724oic.276.1649949539942; Thu, 14 Apr 2022 08:18:59 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c19-20020a9d7853000000b005cdbc0f02ccsm106314otm.68.2022.04.14.08.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 08:18:59 -0700 (PDT) Received: (nullmailer pid 2073887 invoked by uid 1000); Thu, 14 Apr 2022 15:18:58 -0000 Date: Thu, 14 Apr 2022 10:18:58 -0500 From: Rob Herring To: =?utf-8?B?cWluamlhblvopoPlgaVd?= Cc: Krzysztof Kozlowski , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, Apr 14, 2022 at 07:06:12AM +0000, qinjian[覃健] wrote: > > > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > > + > > > +#define XTAL 27000000 > > > > This looks like frequency which usually does not belong to bindings. Why > > do you need it here? > > > > OK, I'll remove it. If that's the input frequency to the clock controller and it could possibly change, then it should be defined in DT with a 'fixed-clock' node and 'clocks' property in the clock controller. Rob