Re: [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver

Stephen Boyd
2022-04-23T01:54:00Z

Quoting Bjorn Andersson (2022-04-22 16:00:13)
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> new file mode 100644
> index 000000000000..16bfe62efca2
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -0,0 +1,7451 @@
[...]
> +static struct clk_branch gcc_video_vcodec_throttle_clk = {
> + .halt_reg = 0x28020,
> + .halt_check = BRANCH_HALT_SKIP,
> + .hwcg_reg = 0x28020,
> + .hwcg_bit = 1,
> + .clkr = {
> + .enable_reg = 0x28020,
> + .enable_mask = BIT(0),
> + .hw.init = &(struct clk_init_data){

The clk_init_data can be const too, right?

> + .name = "gcc_video_vcodec_throttle_clk",
> + .ops = &clk_branch2_ops,
> + },
> + },
> +};