Re: [PATCH 1/7] clk: imx93: use adc_root as the parent clock of adc1

Abel Vesa
2022-06-15T21:31:21Z

On 22-06-09 21:28:56, Peng Fan (OSS) wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> When debug, find after system boot up, all adc register operation
> will trigger system hang, this is because the internal adc ipg
> clock is gate off. In dts, only reference the IMX93_CLK_ADC1_GATE,
> which is adc1, no one touch the adc_root, so adc_root will be gate
> off automatically after system boot up.
>
> Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
> drivers/clk/imx/clk-imx93.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index edcc87661d1f..172cd56c9610 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -150,7 +150,7 @@ static const struct imx93_clk_ccgr {
> { IMX93_CLK_A55_GATE, "a55", "a55_root", 0x8000, },
> /* M33 critical clk for system run */
> { IMX93_CLK_CM33_GATE, "cm33", "m33_root", 0x8040, CLK_IS_CRITICAL },
> - { IMX93_CLK_ADC1_GATE, "adc1", "osc_24m", 0x82c0, },
> + { IMX93_CLK_ADC1_GATE, "adc1", "adc_root", 0x82c0, },
> { IMX93_CLK_WDOG1_GATE, "wdog1", "osc_24m", 0x8300, },
> { IMX93_CLK_WDOG2_GATE, "wdog2", "osc_24m", 0x8340, },
> { IMX93_CLK_WDOG3_GATE, "wdog3", "osc_24m", 0x8380, },
> --
> 2.25.1
>