From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E706C433EF for ; Fri, 17 Jun 2022 17:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382911AbiFQRUV (ORCPT ); Fri, 17 Jun 2022 13:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbiFQRUU (ORCPT ); Fri, 17 Jun 2022 13:20:20 -0400 X-Greylist: delayed 360 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 17 Jun 2022 10:20:19 PDT Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [81.169.146.166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6DC034B8A for ; Fri, 17 Jun 2022 10:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1655486056; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=W2z+oIQknW7onhzoqKNstfGLD4z+lXrDmFliVixL0m0=; b=ivqIgo9Kc5ghX3TUXXOz/PHqkpfxKoqatyueuEhQ6x0UEvRYKDbn4ieBsQcywZpYQk AzZvEUliMonjVG0BB4xgzQkodyqTmPQUSuEc/fIrohPszxvPxzJqJaX9FIVuDdb5Tb+H d+28rVZzgHeH+fhLvvYX6aGMCFUuD9zMZNgF3yYabbTCQxnsSRojtMWXmrAd+HR3Kb0b H8mIPcX1atA9XQeDNeyne5Z7alfjGy6rASAMqAboKzL/FT0TL59DcyL0jx1RSDYgNoC4 u+uVRo5LcThzC46DuQqUNISCMa3+wmuoN8uNYTcnPpL6MhQX4PBisHj0hWIaj+u/uSKr SQ5Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u267FZF9PwpcNKLUrK8+86Y=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.46.0 AUTH) with ESMTPSA id g32597y5HHEF8mG (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 17 Jun 2022 19:14:15 +0200 (CEST) Date: Fri, 17 Jun 2022 19:14:08 +0200 From: Stephan Gerhold To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 7/7] arm64: dts: qcom: msm8916: add clocks to the GCC device node Message-ID: References: <20220617144714.817765-1-dmitry.baryshkov@linaro.org> <20220617144714.817765-8-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220617144714.817765-8-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Dmitry, Thanks for cleaning up MSM8916! :) On Fri, Jun 17, 2022 at 05:47:14PM +0300, Dmitry Baryshkov wrote: > As we are converting this platform to use DT clock bindings, add clocks > and clock-names properties to the MMCC device tree node. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 05472510e29d..e905415b3456 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -934,6 +934,20 @@ gcc: clock-controller@1800000 { > #reset-cells = <1>; > #power-domain-cells = <1>; > reg = <0x01800000 0x80000>; > + clocks = <&rpmcc RPM_SMD_BB_CLK1_PIN>, This should be <&xo_board> to avoid functional changes. If we want to change this to the actual votable clock later this should probably be <&rpmcc RPM_SMD_XO_CLK_SRC>. AFAIK that clock exists in RPM on MSM8916 but was never added to the clk-smd-rpm driver (for MSM8916). Not sure where the pin-controlled BB_CLK1 is coming from here. :) Thanks, Stephan