From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92692C43334 for ; Wed, 6 Jul 2022 20:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233533AbiGFUkn (ORCPT ); Wed, 6 Jul 2022 16:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233173AbiGFUkm (ORCPT ); Wed, 6 Jul 2022 16:40:42 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4EC024F21 for ; Wed, 6 Jul 2022 13:40:41 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id t26-20020a9d775a000000b006168f7563daso12622855otl.2 for ; Wed, 06 Jul 2022 13:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jbu+Xolfw/UCGkWoc/N/K4GT7EYnQrpnk3gnXwJ0aDs=; b=uE2rBU+ye6xoSUBC+1Xj831S1uRcJlkgDR1ThqSVS8k4uhsyh1wya8Knai7vTdCsWL PLikT8TA1iuktX4z2LVa7ZNxSl/w58LNiisUyWC5ablf02Da3u+8shynD+jgifvnBh/l 7RwB3vHs+rJBYgJt5HMaP47DYx5Ygz8BPqVNc7WT7X9udadKvW7f3vaGijyBjm3Py2Bb ygvPfb0HgfcRYGspJ7wyjgdXocbC4KccCtqf09ROP8FONKSz+5DifoMmXYOHNz8wsmSD Wc1S1IzxbsWaFUEDXWJN5i+1Ctago0S+V1ZXtPjOyUECAeivezpBp+GMBUK2Zag0PJBf kOJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jbu+Xolfw/UCGkWoc/N/K4GT7EYnQrpnk3gnXwJ0aDs=; b=RLL66QwG4WlEVuZTglOdoAES+vywbbYE2Qebd87R9CNm8izfzbeILXTeoc6MpAWl9r yymH1n1mlrrjXPOjl+JSxekLEtAJvO5yxSEhnBfnQYOrdPSaWjRArNAwdivqeTlnvpHD Iq4SzSaQ9+QzpF6cLfjlftptESlljgQIDBKi+CrgbgAmJ2k4/JMEj97R/jvi2EXdudpE DQDiUv+OkQSxHGUuN4v49cCscAvz2vCPS4foFwmY5UTESKUvC3y/RZeGVVz3ZnSQ4wHv YpGR4KjlD3cZWFpK+EXdXPJb3pSd2PWwwx3ufI3HHY4P+GcxxQzXo2j5g56usYB623dD qw5A== X-Gm-Message-State: AJIora8oxOImKm/HfaV29tivZL2pbXh5Qmkcxv8rWKRLFOGaUFV8AStt 4/qNa9TB/oTIy6S1npAj49pC6Q== X-Google-Smtp-Source: AGRyM1sNeHBBsJB/+2f9iqPz+44tu1Q+eJXIEssGpbPlgYCnk0Shf1qjLZP2HH2kuWCo6jiaotot+g== X-Received: by 2002:a9d:7154:0:b0:618:d838:3a07 with SMTP id y20-20020a9d7154000000b00618d8383a07mr12799746otj.158.1657140041071; Wed, 06 Jul 2022 13:40:41 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f21-20020a056830309500b00616a2aa298asm16415803ots.75.2022.07.06.13.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 13:40:40 -0700 (PDT) Date: Wed, 6 Jul 2022 15:40:38 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Andy Gross , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v1 2/4] clk: qcom: Add support for Display Clock Controller on SM8450 Message-ID: References: <20220623114737.247703-1-dmitry.baryshkov@linaro.org> <20220623114737.247703-3-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220623114737.247703-3-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu 23 Jun 06:47 CDT 2022, Dmitry Baryshkov wrote: > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index bc4dcf356d82..f409b891fce4 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -635,6 +635,15 @@ config SM_DISPCC_6350 > Say Y if you want to support display devices and functionality such as > splash screen. > > +config SM_DISPCC_8450 > + tristate "SM8450 Display Clock Controller" > + depends on SM_GCC_8450 > + help > + Support for the display clock controller on Qualcomm Technologies, Inc > + SM8250 devices. s/2/4/ > + Say Y if you want to support display devices and functionality such as > + splash screen. > + [..] > diff --git a/drivers/clk/qcom/dispcc-sm8450.c b/drivers/clk/qcom/dispcc-sm8450.c [..] > +static struct clk_alpha_pll disp_cc_pll0 = { > + .offset = 0x0, > + .vco_table = lucid_evo_vco, > + .num_vco = ARRAY_SIZE(lucid_evo_vco), > + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], > + .clkr = { > + .hw.init = &(struct clk_init_data){ > + .name = "disp_cc_pll0", > + .parent_data = &(const struct clk_parent_data){ > + .fw_name = "bi_tcxo", Can we please have this transitioned to using .index as in the other new clock drivers? Also, you have a bi_tcxo clk_parent_data below, how about using that? And lastly, could I please have a space inbetween ) and {? > + }, > + .num_parents = 1, > + .ops = &clk_alpha_pll_reset_lucid_evo_ops, > + }, > + }, > +}; > + [..] > +static int __init disp_cc_sm8450_init(void) > +{ > + return platform_driver_register(&disp_cc_sm8450_driver); > +} > +subsys_initcall(disp_cc_sm8450_init); > + > +static void __exit disp_cc_sm8450_exit(void) > +{ > + platform_driver_unregister(&disp_cc_sm8450_driver); > +} > +module_exit(disp_cc_sm8450_exit); You should be able to module_platform_driver() this instead. > + > +MODULE_DESCRIPTION("QTI DISP_CC WAIPIO Driver"); While not secret, please update this to use SM8450 and perhaps a more human readable form? > +MODULE_LICENSE("GPL v2"); Please change this to MODULE_LICENSE("GPL") Regards, Bjorn