Linux clock framework development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: renesas: r9a06g032: add restart handler
Date: Thu, 28 Nov 2024 09:45:00 +0100	[thread overview]
Message-ID: <Z0gtjA3RCLzDaUX9@ninjato> (raw)
In-Reply-To: <CAMuHMdW1KpmsHEFUpKYNe96cEzUEEzGUXC52o4Fand6R+o9Y=A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Geert,

> > I got a RZ/N1D now. Before I start the real work, I need working
> > 'reboot' for fluent hacking :)
> 
> Yes, we all do ;-)

Well, previous N1D developers didn't, it seems...

> > +       error = register_restart_handler(&clocks->restart_nb);
> 
> You can simplify using devm_register_sys_off_handler(), cfr.
> drivers/power/reset/rmobile-reset.c.

Ok, will do, thanks for the pointer. One question, though...

> 
> > +       if (error)
> > +               dev_warn(dev, "couldn't register restart handler (%d)\n", error);

rmobile bails out on error. I still think a warning is enough. What is
your preference?

Thanks and happy hacking,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-11-28  8:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 19:31 [PATCH] clk: renesas: r9a06g032: add restart handler Wolfram Sang
2024-11-27 12:47 ` Geert Uytterhoeven
2024-11-28  8:45   ` Wolfram Sang [this message]
2024-11-28  8:47     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0gtjA3RCLzDaUX9@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox