From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6751E2629C for ; Tue, 11 Mar 2025 14:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741703777; cv=none; b=cDXHYJE4h/VcRg7HrOScE61uB2wf4aWB4tXK+XpPpB1tLHav+Y+EkPiOyGq6uKHrLhLkVo2MRb3Nq2dzXMG+l4HuaOwP5VN57lH2W+tE6gMM9YIszqKt7v/9FwNdSWa1EMsWmGEA3d/BcvmLWYV9V4BS680e/vfMPGZSE7N4+j8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741703777; c=relaxed/simple; bh=6LVHLF6PwX8YsonPvmbJwU0JO6y743wuUzDiLPWIImE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OeIzrVoyUDg8RmRyqdRLuSbMOJ6OTj8qdH+AloaFf5WdBoASQ0oUi8zKVYOgUIq53a4AGpSlRk42FDMNxUf8K+iAOMNqKy6XS88Qn36+qDT3a0aVZ5AnJaxCmUyjZs9ouLJCIPAODykpfv6oFC4884WNdeaI/alkFOcP8aZKQg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Wlxoky82; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Wlxoky82" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3912fdddf8fso2842493f8f.1 for ; Tue, 11 Mar 2025 07:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741703774; x=1742308574; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QVGY1YdKpatvu9ORUu7u/Y2xJ4feOuJRGzkvoJubghM=; b=Wlxoky821Hdf1+HDRFQI8GSJ+xfITZnxWkrT8O8QeqG3ei/oJBc4cHDaUYBGVON96a uar/T/KwZh73HwHRHToJloBV8o3YON8SeC1ab+BsqH1ujIK8rtBPjE0m23ktlGtMix9y BaNdnAxqgzuiJ2rAp++0s3xAcVGsBT6Zagy0XD9gQ46MHCp7rXe3Q33K4YAhZE2/QtWg jxmZaF5k8YnWO1t4nZ1xvzNIJmh/UdU7mE/TSDb1O/3rw+ZSK7NiASx5wSnQFSbw//0h H47AaCZhLYe3kUV2iAz+WdshLfx/RySlwsI52QXfZsJ7nGjStV+r8YnDg4E7QkoUPNh4 9bOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741703774; x=1742308574; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QVGY1YdKpatvu9ORUu7u/Y2xJ4feOuJRGzkvoJubghM=; b=HwTCf8f0QcOS/cxkZKRYZDnyGuHuflzAT/aX6VocRYUL7/K9GeGGRkSbtvKyrzk9RA vewL4t62qmVqtDbVeC2HuLWY9Y5KUNGhK5VH9VryX3mZUf+6FxaReX0u5/mzIGhoYd+O r+dzm4xbXjryebPGT/4WeH4I8pIFutZIqoskqy7zO1Cve34NAYeJp2khQRrAHHuP0RKE j2rcQ7+B2xFZZf4BtpjtgRBCPyGyJQfkKoj6y2LDz50EF3UuOHsuutDG0zIzkN/bOj2S 4nXC+F0yx8ccmT/zgjzbPqJdElRkj1cPcVp4+q9KcwTzc1ZvMQfJxV90jhv+4V+XmzID 2CVA== X-Forwarded-Encrypted: i=1; AJvYcCUr09IBd5oYPcgJpPP2bvLRB3lWhSzpSZCu48X1oaG9/5FBrwLd9k3v0I7CrOwAi3WrkaLm/r5N/ks=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7s0QbAg9gcMl+MAdSB10zCM4VcGguYG/2NyJpevyaedx3VtCm U1ofrNyxNqTr98pz1WW94OVxzWDxhmYuWFuKSyPZ5a4hMmOizclteukwsEw/8jo= X-Gm-Gg: ASbGncvBTsT5Jk8V3Jdl5P+z7xt/jO9w0Ux887RqBiLH/Or0IHXzjt/2gpuvG9vFsiG XYISRjI0yO67e7U/oSFHKmaKhjlQKXNmoJlDwL36IibkxfUpvFPShrn+Mj+UA+PCqYdQJl1SV0c KLaFricOwujLYdOhIc9X/efhbR7/EBqBSNMDH1aeXzdc0FPLfKmqnFMN5CaLDlUXgzSklNSgmU0 OKFz8sK0DIiAYeF1Z/BdHTXePEcofYNzQYgeXFzMW2DAmkuw6eR4QOe1xPNd+6iCs4M2RjmSsMQ B7lbEDe8giOiLiKWAz4tt3JCVqNsMYaYKVy6Iv8IBjfXzyQVPnHkRn9SwQ== X-Google-Smtp-Source: AGHT+IErzBNORRKa85qMLnrTIo9THTPP0FLW0fdPXNcjP60zrb0rXKoRA/K5g0/ZRtEM4ho9Q+BqZA== X-Received: by 2002:a05:6000:1fa6:b0:38d:fede:54f8 with SMTP id ffacd0b85a97d-3926cb664eamr5073516f8f.16.1741703773763; Tue, 11 Mar 2025 07:36:13 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfba888sm18559270f8f.16.2025.03.11.07.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 07:36:13 -0700 (PDT) Date: Tue, 11 Mar 2025 15:36:11 +0100 From: Petr Mladek To: Luca Ceresoli , Daniel Lezcano Cc: "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , Alex Shi , Yanteng Si , Binbin Zhou , Thomas Petazzoni , Michael Turquette , Stephen Boyd , Geert Uytterhoeven , Liu Ying , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 2/2] vsprintf: remove redundant and unused %pCn format specifier Message-ID: References: <20250311-vsprintf-pcn-v2-0-0af40fc7dee4@bootlin.com> <20250311-vsprintf-pcn-v2-2-0af40fc7dee4@bootlin.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250311-vsprintf-pcn-v2-2-0af40fc7dee4@bootlin.com> On Tue 2025-03-11 10:21:23, Luca Ceresoli wrote: > %pC and %pCn print the same string, and commit 900cca294425 ("lib/vsprintf: > add %pC{,n,r} format specifiers for clocks") introducing them does not > clarify any intended difference. It can be assumed %pC is a default for > %pCn as some other specifiers do, but not all are consistent with this > policy. Moreover there is now no other suffix other than 'n', which makes a > default not really useful. > > All users in the kernel were using %pC except for one which has been > converted. So now remove %pCn and all the unnecessary extra code and > documentation. > > Acked-by: Stephen Boyd > Reviewed-by: Geert Uytterhoeven > Signed-off-by: Luca Ceresoli Makes sense. Looks and works well, so: Reviewed-by: Petr Mladek Tested-by: Petr Mladek Daniel, if I get it correctly, you have already taken the 1st patch. Would you mind to take also this patch using the same tree, please? Otherwise, we would need to coordinate pull requests in the upcoming merge window ;-) Best Regards, Petr