Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions

Jiri Pirko
2023-03-16T16:16:55Z

Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote:

[...]

>+int dpll_device_register(struct dpll_device *dpll, enum dpll_type type,
>+ struct dpll_device_ops *ops, void *priv,

ops should be const

>+ struct device *owner)

[...]

>+
>+static int
>+__dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin,
>+ struct dpll_pin_ops *ops, void *priv,

ops should be const

>+ const char *rclk_device_name)
>+{ …