Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions

Jiri Pirko
2023-03-16T12:20:18Z

Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote:

[...]

>+/**
>+ * dpll_pin_unregister - deregister dpll pin from dpll device
>+ * @dpll: registered dpll pointer
>+ * @pin: pointer to a pin
>+ *
>+ * Note: It does not free the memory
>+ */
>+int dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin)

Make this return void. Function does not report anything useful,
non-0 is only in case of WARN_ON. Nobody is going to check that ever
anyway.

>+{
>+ if (WARN_ON(xa_empty(&dpll->pin_refs)))
>+ return -ENOENT;
>+
>+ mutex_lock(&dpll_device_xa_lock);
>+ mutex_lock(&dpll_pin_xa_lock);
>+ __dpll_pin_unregister(dpll, pin);
>+ mutex_unlock(&dpll_pin_xa_lock);
>+ mutex_unlock(&dpll_device_xa_lock);
>+
>+ return 0;
>+}
>+EXPORT_SYMBOL_GPL(dpll_pin_unregister); …