Re: [PATCH RFC v6 6/6] ptp_ocp: implement DPLL ops

Jiri Pirko
2023-03-16T12:13:22Z

Sun, Mar 12, 2023 at 03:28:07AM CET, vadfed@meta.com wrote:

[...]

>@@ -4243,6 +4430,8 @@ ptp_ocp_remove(struct pci_dev *pdev)
> struct ptp_ocp *bp = pci_get_drvdata(pdev);
> struct devlink *devlink = priv_to_devlink(bp);
>

You are missing pins unregister and put here.

Btw, It would be probably good to add a WARN_ON into
dpll_device_unregister() to catch bugs like this one.

>+ dpll_device_unregister(bp->dpll);
>+ dpll_device_put(bp->dpll);
> devlink_unregister(devlink);
> ptp_ocp_detach(bp);
> pci_disable_device(pdev);
>--
>2.34.1
>