Re: [PATCH RFC v6 6/6] ptp_ocp: implement DPLL ops

Jiri Pirko
2023-03-15T15:34:39Z

Sun, Mar 12, 2023 at 03:28:07AM CET, vadfed@meta.com wrote:

[...]

>@@ -4226,8 +4377,44 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> ptp_ocp_info(bp);
> devlink_register(devlink);
>- return 0;
>
>+ clkid = pci_get_dsn(pdev);
>+ bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE);
>+ if (!bp->dpll) {

You have to use IS_ERR() here. Same problem in ice. …