Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions

Vadim Fedorenko
2023-04-17T15:53:29Z

On 16/04/2023 17:23, Jiri Pirko wrote:
> Tue, Apr 11, 2023 at 12:31:49AM CEST, kuba@kernel.org wrote:
>> On Sun, 9 Apr 2023 09:51:48 +0200 Jiri Pirko wrote:
>>> Wait, not sure you get the format of the "name". It does not contain any
>>> bus address, so the auxdev issue you pointed out is not applicable.
>>> It is driver/clock_id/index.
>>> All 3 are stable and user can rely on them. Do you see any issue in
>>> that?
>>
>> What is index? I thought you don't want an index and yet there is one,
>> just scoped by random attributes :(
>
> Index internal within a single instance. Like Intel guys, they have 1
> clock wired up with multiple DPLLs. The driver gives every DPLL index.
> This is internal, totally up to the driver decision. Similar concept to
> devlink port index.

It feels like a dead-lock in conversation here. We have to agree on
something because for now it's the only blocker to post the next version
with all the comments from the previous one addressed in the code.
My position here is that I'm ok to have any of the properties being an
identifier as well as keep both of them, the code already has all the
lines to support any decision. I just to want to go back to this part
again in the next iteration.