From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED4FFC6FD1F for ; Thu, 16 Mar 2023 15:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbjCPPUL (ORCPT ); Thu, 16 Mar 2023 11:20:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbjCPPUE (ORCPT ); Thu, 16 Mar 2023 11:20:04 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C637DF715 for ; Thu, 16 Mar 2023 08:19:56 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id t15so1873139wrz.7 for ; Thu, 16 Mar 2023 08:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678979995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TgWMfzhObrj0kUZQtkGZokHYyYa6G72Fv0Uf4IJo0P4=; b=OFA5D4OZEBeF2ec1JKLo7kLqcCKk0K3Iu1MbggXzM4WF3NoHiJL77vDxG0vtpwZz+5 p+BgdPe11Hu93yERFTklAAYhi0sWI3Ly3v39IzDxjIhmp7w+cdZL3lxyPChU8afsDp6c a1kVaqaUa7dUgZY/PnjT8Wj1M5S01gvY3JmENdDDcRAb0HWkK4sxKattyCXD4g1TpVUB /wXOFpr7LfigmKLWb/9V5d2RR8HZ37xsyLTyGn1JZ48uQi42EctJjRheYwu3vbFNNojK sk7MIp5YCYcATZmOI3ivgzozrwVMx9IBJadiuvbG8Jp18frgzdoDuojEn984zUmhi0DY CI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678979995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TgWMfzhObrj0kUZQtkGZokHYyYa6G72Fv0Uf4IJo0P4=; b=lXSJVGIwtK5RdD5sL2g+JD7lPc9eIpXd8D/rcMAUVcLq016AOldwYEXeHdsUcMc/k7 ZshWkJFZTA5O+3ieMmrEDiVxymiAKKJcORTHVjpFFIFV9Wkax1/k840JMHMtoewoHJfn Q2kpC3Sk+635u3HlslGi8pYQ7rVvTinNNdqF5yH7d1yHaYbGKWAefnC63LwCm056WR0V ZQPh55C+J/Ti0SbVbuWAoiaxDr4Kx8GDChTsHd2P7BAtlia3MGsYuUO6V7BYIbwz2VhI JJc6+dULQIuFzMfLEX9Z1BzHn2iK6+1rUGKMmr+1+c6QjhcIywWFVOXvH15n0bwPN5s+ qbRQ== X-Gm-Message-State: AO0yUKVAaVIjskfx4U/BWTho6fspzX29zHFY1ZitIBPnZYhy07E25E6V z1rxR7FmlGVu8PwFoerU1sdzEw== X-Google-Smtp-Source: AK7set/GLdd2/EehnrOKR4cb06GbiP0IsPpRFlvHvmNN0qsnqJJJAk8jeFWizMQY8mw4hy0TH4WzCA== X-Received: by 2002:a5d:608d:0:b0:2c7:d7c:7d0 with SMTP id w13-20020a5d608d000000b002c70d7c07d0mr4788153wrt.22.1678979994646; Thu, 16 Mar 2023 08:19:54 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id r2-20020adff702000000b002c573cff730sm7482799wrp.68.2023.03.16.08.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 08:19:54 -0700 (PDT) Date: Thu, 16 Mar 2023 16:19:52 +0100 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: Vadim Fedorenko , Jakub Kicinski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros , mschmidt , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 1/6] dpll: spec: Add Netlink spec in YAML Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-2-vadfed@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Thu, Mar 16, 2023 at 02:45:10PM CET, jiri@resnulli.us wrote: >Thu, Mar 16, 2023 at 02:15:59PM CET, arkadiusz.kubalewski@intel.com wrote: [...] >>>>+ flags: [ admin-perm ] >>>>+ >>>>+ do: >>>>+ pre: dpll-pre-doit >>>>+ post: dpll-post-doit >>>>+ request: >>>>+ attributes: >>>>+ - id >>>>+ - bus-name >>>>+ - dev-name >>>>+ - mode >>> >>>Hmm, shouldn't source-pin-index be here as well? >> >>No, there is no set for this. >>For manual mode user selects the pin by setting enabled state on the one >>he needs to recover signal from. >> >>source-pin-index is read only, returns active source. > >Okay, got it. Then why do we have this assymetric approach? Just have >the enabled state to serve the user to see which one is selected, no? >This would help to avoid confusion (like mine) and allow not to create >inconsistencies (like no pin enabled yet driver to return some source >pin index) Actually, for mlx5 implementation, would be non-trivial to implement this, as each of the pin/port is instantiated and controlled by separate pci backend. Could you please remove, it is not needed and has potential and real issues. [...]