Re: [PATCH 01/18] dt-bindings: opp: opp-v2-kryo-cpu: support Qualcomm Krait SoCs

Krzysztof Kozlowski
2023-06-21T08:51:39Z

On 14/06/2023 22:11, Dmitry Baryshkov wrote:

>> Why?
>>
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>
>> You are changing the type. No. It should be fixed instead (enum applies
>> to items).
>
> Currenlty this bindings are only usable for msm8996/msm8996pro. As such
> we listed opp-supported-hw values that are applicable to this platform.
> This series adds support for apq8064 platform, which will add new items
> to this enum. I think it is not very sensible to list all of them here.

Sure, but this is uint32-matrix, so don't change the type to something else.

>
> However granted there is already a good enough base type definition, I
> think it would be better to drop the $ref, drop the enum, add ': true'
> (is it necessary if we have a description already?) and expand
> documentation.

Probably this should be constrained to only one value with:
items:
- items:
- description: foo bar

Best regards,
Krzysztof