Re: [PATCH v3 2/4] dt-bindings: clock: mediatek: add clock controllers of MT7988

Krzysztof Kozlowski
2023-12-07T17:04:14Z

On 06/12/2023 13:45, Daniel Golle wrote:
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - const: mediatek,mt7988-ethwarp
>>> + - const: syscon
>>> + - const: simple-mfd
>>
>> No, this is not a mfd, I say.
>>
>> Prove me wrong! :-)
>
> https://github.com/dangowrt/linux/blob/mt7988-for-next/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L564
>
> The 'simple-mfd' compatible is required to have the Linux
> kernel probe drivers for sub-nodes -- several drivers will act on
> the different aspects of the circuit exposed at this memory range.
> From what I understand, this is the definition of a MFD.

We know what is MFD, so no need to teach us. We expect you to look at
this. You do not have subnodes, so MFD is pointless. Showing DTSI means
nothing except that you did not test your bindings.

Best regards,
Krzysztof