From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v3 02/15] clk: qcom: Use qcom_branch_set_clk_en()
Date: Wed, 20 Dec 2023 09:25:14 +0100 [thread overview]
Message-ID: <ZYKk6ohfkHpSIJN7@hovoldconsulting.com> (raw)
In-Reply-To: <20230717-topic-branch_aon_cleanup-v3-2-3e31bce9c626@linaro.org>
On Wed, Dec 20, 2023 at 01:30:43AM +0100, Konrad Dybcio wrote:
> Instead of magically poking at the bit0 of branch clocks' CBCR, use
> the newly introduced helper.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index bfb77931e868..1ba78990b9f4 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7543,21 +7543,15 @@ static int gcc_sc8280xp_probe(struct platform_device *pdev)
> goto err_put_rpm;
> }
>
> - /*
> - * Keep the clocks always-ON
I think you should keep this part of the comment in some form
throughout, for example:
/* Keep some clocks always on */
qcom_branch_set_clk_en(...);
...
> - * GCC_CAMERA_AHB_CLK, GCC_CAMERA_XO_CLK, GCC_DISP_AHB_CLK,
> - * GCC_DISP_XO_CLK, GCC_GPU_CFG_AHB_CLK, GCC_VIDEO_AHB_CLK,
> - * GCC_VIDEO_XO_CLK, GCC_DISP1_AHB_CLK, GCC_DISP1_XO_CLK
> - */
> - regmap_update_bits(regmap, 0x26004, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x26020, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x27004, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x27028, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x71004, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x28004, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x28028, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0xbb004, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0xbb028, BIT(0), BIT(0));
> + qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x26020); /* GCC_CAMERA_XO_CLK */
> + qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x27028); /* GCC_DISP_XO_CLK */
> + qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x28004); /* GCC_VIDEO_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0x28028); /* GCC_VIDEO_XO_CLK */
> + qcom_branch_set_clk_en(regmap, 0xbb004); /* GCC_DISP1_AHB_CLK */
> + qcom_branch_set_clk_en(regmap, 0xbb028); /* GCC_DISP1_XO_CLK */
>
> ret = qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_dfs_clocks));
> if (ret)
Johan
next prev parent reply other threads:[~2023-12-20 8:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 0:30 [PATCH v3 00/15] Unregister critical branch clocks + some RPM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 01/15] clk: qcom: branch: Add a helper for setting the enable bit Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 02/15] clk: qcom: Use qcom_branch_set_clk_en() Konrad Dybcio
2023-12-20 8:25 ` Johan Hovold [this message]
2023-12-20 12:16 ` Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 03/15] clk: qcom: gcc-sm6375: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 04/15] clk: qcom: gcc-sm6375: Add runtime PM Konrad Dybcio
2023-12-20 9:26 ` Johan Hovold
2023-12-20 12:26 ` Konrad Dybcio
2023-12-20 12:48 ` Johan Hovold
2023-12-20 13:13 ` Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 05/15] clk: qcom: gpucc-sm6375: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 06/15] clk: qcom: gpucc-sm6115: " Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 07/15] clk: qcom: gpucc-sm6115: Add runtime PM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 08/15] clk: qcom: gcc-sm6115: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 09/15] clk: qcom: gcc-sm6115: Add runtime PM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 10/15] clk: qcom: gcc-qcm2290: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 11/15] clk: qcom: gcc-qcm2290: Add runtime PM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 12/15] arm64: dts: qcom: sm6375: Add VDD_CX to GCC Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 13/15] arm64: dts: qcom: qcm2290: " Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 14/15] arm64: dts: qcom: sm6115: " Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 15/15] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CC Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYKk6ohfkHpSIJN7@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox