On Mon, Jan 08, 2024 at 04:33:49PM +0100, Geert Uytterhoeven wrote: > Currently, all Kconfig symbols for R-Car Gen4 SoCs select the > ARCH_RCAR_GEN3 SoC family symbol, which might confuse the casual reader. > > Fix this by introducing a new SoC family symbol for R-Car Gen4 SoCs. > For now this just selects ARCH_RCAR_GEN3, to avoid duplication, and to > relax dependencies. > > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Wolfram Sang > Once "[PATCH] i2c: rcar: Prepare for the advent of ARCH_RCAR_GEN4"[1] > has been applied, ARCH_RCAR_GEN4 can stop selecting ARCH_RCAR_GEN3. Oh, that's me :) > I'm open for suggestions how to improve this. > Perhaps factor out common parts into ARCH_RCAR? I kinda like the situation after this patch. I'd think using ARCH_RCAR might hurt readability. Also, if Gen5 needs to modify ARCH_RCAR, then we need to fix up old archs. Potential regressions ahead.