Re: [PATCH] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE

Marek Szyprowski
2024-04-26T05:24:37Z

On 26.04.2024 02:24, William McVicker wrote:
> On 04/25/2024, Marek Szyprowski wrote:
>> Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
>> module driver") this driver is instantiated as MFD-cell (matched by
>> platform device name) not as a real platform device created by OF code.
>> Remove then of_match_table and related MODULE_DEVICE_TABLE to avoid
>> further confusion.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> drivers/clk/samsung/clk-exynos-clkout.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
>> index 503c6f5b20d5..0c7f4e2aa366 100644
>> --- a/drivers/clk/samsung/clk-exynos-clkout.c
>> +++ b/drivers/clk/samsung/clk-exynos-clkout.c
>> @@ -75,7 +75,6 @@ static const struct of_device_id exynos_clkout_ids[] = {
>> .data = &exynos_clkout_exynos5,
>> }, { }
>> };
>> -MODULE_DEVICE_TABLE(of, exynos_clkout_ids);
> I understand these are duplicates of the exynos-pmu driver, but was wondering
> if this will impact the exynos-clkout module from getting auto-loaded? Without
> the MODULE_DEVICE_TABLE() defined, the aliases won't be created that trigger
> udev to load this module and the mfd driver is obviously not going to load it.

This driver loaded and matched only against the platform device name
("exynos-clkout") since the mentioned commit 9484f2cb8332. These OF IDs
defined as MODULE_DEVICE_TABLE and of_match_table are leftovers from the
old (pre-9484f2cb8332) instantiating method.and should be removed by
that commit too.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland