From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03EA61422C5 for ; Fri, 28 Jun 2024 08:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719562492; cv=none; b=WHkmDaujSbxz+KmuV/omEscVlLFs/qKHHjE1AbWjEHw/9vlb/Ij7EoZDGV4rF6IMhizWsfdTB2583M0/SXbDtsVLeOwlK76y3OTSPTJ1vIHS0F1gMBwpGbQki2T4z+HBR9BDwlDHW7Xk+usOtEV+KMQF/t4iYsGw+1MPvANloII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719562492; c=relaxed/simple; bh=aIFPuYhbMEspAOzXfR/bH+Fm5KNxHLFrbI/0BWwUaQg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iCjDA9uXuncQmoQNm2j2jPT/VmuyQnBL7zuoJyiUbCw231PXNSGmMsvZ/Uwe82IpIqKQWcMqCIFZgN3B2I1hGbgKzRsffngwsMGM23oS6g2XqIoKqCkhSBlPVaSiDaayeC6p7bECnweh6ROykmP80vxipaSpeITFKJjBwZdItsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PAn8MuQD; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PAn8MuQD" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-425624255f3so1976455e9.0 for ; Fri, 28 Jun 2024 01:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719562489; x=1720167289; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5p5vZCwu+kIfI6E/jSCcA3j2SGSRGBxA6ocPxaq30sA=; b=PAn8MuQDujwx80dRqoIi+PbRmh1eU2eqYgBkBvgXAgoZPwYHT6Ie2j5som5T5J8P6q yHNGtPkzcXYf7YD/ygjD2uqmkSaQ5y1mNxdCThr4e+EGoqHk/l2VOHp8QFU+2G7eXfer 12X57xtqI0TFr2Iqll4m17tNQs0IBgxl2R/3i2dDe7iPZWfgmQxyzrTbX9jEL3lh1l6F NMlEFscCnAlZKQLAio4RrDLedictefVqCamWvtuL0RJCOKYEPB8GZKZUjE3ieZZB/B6j Jr9SUkgj115j7cfEaGMRyNysiSyXE5KWvdi2XLjj4gahLtPNVknU2HETyyVYiOO0W7vA Ct/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719562489; x=1720167289; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5p5vZCwu+kIfI6E/jSCcA3j2SGSRGBxA6ocPxaq30sA=; b=m+xU39RUXCftiddgqW9a+suYIll0jSAlbKCbsNX/2xzaz+iq/xPFY00vXitk4gh8li EMDMCyQZTZhfh+yvAhfNYlUvvmW/OI6nbMF5VrUIHU7iINMYwtluRjdpZlJzoLxk8x2h ChZb3CNUuPddQ0WzQ6kfrLSh4mB+rnLD5MzBWxVNhZ/mGKAOKTb6NQoh+Xd/DtQrZfek Wk9jXSxUTxlplBHGii96vplNMg1+I3IxymXQenkJSP71MJIG6C1J8MQtKlciRnY5XKNe ztkr1E84gxk814e2jarWPrbIPdYeNwg5vEQlrb76zuUiiuKpGGqbco+0toPVoVyVNo6U FMhA== X-Forwarded-Encrypted: i=1; AJvYcCWO/hI8ktTGlY0aLscN0sAAUca6+FJggP0K4bNYC9T8zRWgeQx5SWvpBKioS3M3zgd0lvf+V27J/7CKeVhGzA6iSXlz02n0fdeD X-Gm-Message-State: AOJu0Yxfyd7G7zsVn/cJyvcP+Yly5Xh5FuETsIk7Hrnkg41IIBRcrhnH B7UYC+24frY8+1g7bYypph/E3I7cFjdxmMve+0wAEC1AtL//Ox2mBUkG6cIDOSE= X-Google-Smtp-Source: AGHT+IERat1T50yD424DDB+EpCE39bTSKhswb6OkBsxZplNjpH1EV9xixuDz3OSQBaaYIPvhFsoHTw== X-Received: by 2002:a05:600c:1616:b0:421:b65d:2235 with SMTP id 5b1f17b1804b1-4256d4246f3mr8736965e9.0.1719562489347; Fri, 28 Jun 2024 01:14:49 -0700 (PDT) Received: from linaro.org ([82.79.124.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256af5b61bsm23968405e9.17.2024.06.28.01.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 01:14:48 -0700 (PDT) Date: Fri, 28 Jun 2024 11:14:47 +0300 From: Abel Vesa To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: gcc-x1e80100: Set parent rate for USB3 sec and tert PHY pipe clks Message-ID: References: <20240530-x1e80100-clk-gcc-usb3-sec-tert-set-parent-rate-v1-1-7b2b04cad545@linaro.org> <3ukguewuqqm5gmbd3afl62ihysdzkk44j3f2nuqht4gjuf5ruo@zu7jmmnbrpdj> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ukguewuqqm5gmbd3afl62ihysdzkk44j3f2nuqht4gjuf5ruo@zu7jmmnbrpdj> On 24-05-31 02:56:12, Dmitry Baryshkov wrote: > On Thu, May 30, 2024 at 05:05:24PM +0300, Abel Vesa wrote: > > Allow the USB3 second and third GCC PHY pipe clocks to propagate the > > rate to the pipe clocks provided by the QMP combo PHYs. The first > > instance is already doing that. > > Which driver changes the rate of those clocks? Sorry for the late reply. These clocks are consumed by the combo PHYs, so driver is phy-qcom-qmp-combo. This driver doesn't change the rates of the pipe clocks as of yet. The fix is still good, even if it's just to align all three clocks. > > > > > Fixes: ("161b7c401f4b clk: qcom: Add Global Clock controller (GCC) driver for X1E80100") > > Signed-off-by: Abel Vesa > > --- > > drivers/clk/qcom/gcc-x1e80100.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c > > index 1404017be918..8c72fdc99fd9 100644 > > --- a/drivers/clk/qcom/gcc-x1e80100.c > > +++ b/drivers/clk/qcom/gcc-x1e80100.c > > @@ -5269,6 +5269,7 @@ static struct clk_branch gcc_usb3_sec_phy_pipe_clk = { > > &gcc_usb3_sec_phy_pipe_clk_src.clkr.hw, > > }, > > .num_parents = 1, > > + .flags = CLK_SET_RATE_PARENT, > > .ops = &clk_branch2_ops, > > }, > > }, > > @@ -5339,6 +5340,7 @@ static struct clk_branch gcc_usb3_tert_phy_pipe_clk = { > > &gcc_usb3_tert_phy_pipe_clk_src.clkr.hw, > > }, > > .num_parents = 1, > > + .flags = CLK_SET_RATE_PARENT, > > .ops = &clk_branch2_ops, > > }, > > }, > > > > --- > > base-commit: 9d99040b1bc8dbf385a8aa535e9efcdf94466e19 > > change-id: 20240530-x1e80100-clk-gcc-usb3-sec-tert-set-parent-rate-420a9e2113d1 > > > > Best regards, > > -- > > Abel Vesa > > > > -- > With best wishes > Dmitry