* [PATCH] clk: T-Head: Disable on 32-bit Targets
@ 2024-07-19 15:10 Palmer Dabbelt
2024-07-20 17:38 ` Drew Fustini
2024-07-22 21:29 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2024-07-19 15:10 UTC (permalink / raw)
To: sboyd
Cc: mturquette, jszhang, Palmer Dabbelt, dfustini, frank.li,
linux-clk, linux-kernel
From: Palmer Dabbelt <palmer@rivosinc.com>
This fails to build on 32-bit targets because of a missing __udivdi3.
IIRC the right way to fix that is to avoid the division, but I just want
a tree that builds and the only real T-Head platforms are 64-bit right
now.
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
drivers/clk/thead/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/thead/Kconfig b/drivers/clk/thead/Kconfig
index 1710d50bf9d4..95e0d9eb965e 100644
--- a/drivers/clk/thead/Kconfig
+++ b/drivers/clk/thead/Kconfig
@@ -3,6 +3,7 @@
config CLK_THEAD_TH1520_AP
bool "T-HEAD TH1520 AP clock support"
depends on ARCH_THEAD || COMPILE_TEST
+ depends on 64BIT
default ARCH_THEAD
select REGMAP_MMIO
help
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: T-Head: Disable on 32-bit Targets
2024-07-19 15:10 [PATCH] clk: T-Head: Disable on 32-bit Targets Palmer Dabbelt
@ 2024-07-20 17:38 ` Drew Fustini
2024-07-22 21:29 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Drew Fustini @ 2024-07-20 17:38 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: sboyd, mturquette, jszhang, dfustini, frank.li, linux-clk,
linux-kernel
On Fri, Jul 19, 2024 at 08:10:27AM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> This fails to build on 32-bit targets because of a missing __udivdi3.
> IIRC the right way to fix that is to avoid the division, but I just want
> a tree that builds and the only real T-Head platforms are 64-bit right
> now.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> drivers/clk/thead/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/thead/Kconfig b/drivers/clk/thead/Kconfig
> index 1710d50bf9d4..95e0d9eb965e 100644
> --- a/drivers/clk/thead/Kconfig
> +++ b/drivers/clk/thead/Kconfig
> @@ -3,6 +3,7 @@
> config CLK_THEAD_TH1520_AP
> bool "T-HEAD TH1520 AP clock support"
> depends on ARCH_THEAD || COMPILE_TEST
> + depends on 64BIT
> default ARCH_THEAD
> select REGMAP_MMIO
> help
> --
> 2.45.2
>
Acked-by: Drew Fustini <drew@pdp7.com>
Sorry about that. This patch makes sense as the TH1520 SoC is 64-bit
and I see no valid use case to run a 32-bit kernel on it.
Drew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: T-Head: Disable on 32-bit Targets
2024-07-19 15:10 [PATCH] clk: T-Head: Disable on 32-bit Targets Palmer Dabbelt
2024-07-20 17:38 ` Drew Fustini
@ 2024-07-22 21:29 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2024-07-22 21:29 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: mturquette, jszhang, Palmer Dabbelt, dfustini, frank.li,
linux-clk, linux-kernel
Quoting Palmer Dabbelt (2024-07-19 08:10:27)
> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> This fails to build on 32-bit targets because of a missing __udivdi3.
> IIRC the right way to fix that is to avoid the division, but I just want
> a tree that builds and the only real T-Head platforms are 64-bit right
> now.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-22 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-19 15:10 [PATCH] clk: T-Head: Disable on 32-bit Targets Palmer Dabbelt
2024-07-20 17:38 ` Drew Fustini
2024-07-22 21:29 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox