Re: [PATCH 1/7] dt-bindings: clock: airoha: update reg mapping for EN7581 SoC.

Rob Herring
2024-09-03T15:04:39Z

On Sat, Aug 31, 2024 at 09:18:43AM +0200, Lorenzo Bianconi wrote:
> clk-en7523 driver for EN7581 SoC is mapping all the scu memory region
> while it is configuring the chip-scu one via a syscon. Update the reg
> mapping definition for this device. This patch does not introduce any
> backward incompatibility since the dts for EN7581 SoC is not public yet.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../devicetree/bindings/clock/airoha,en7523-scu.yaml | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index 84353fd09428..ca426c328535 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -34,8 +34,8 @@ properties:
> - airoha,en7581-scu
>
> reg:
> - minItems: 2
> - maxItems: 4
> + minItems: 1
> + maxItems: 2

This should really have the 'items' list here instead of in the if/then
schemas.
>
> "#clock-cells":
> description:
> @@ -75,9 +75,6 @@ allOf:
> reg:
> items:
> - description: scu base address
> - - description: misc scu base address
> - - description: reset base address
> - - description: pb scu base address

And then this would be just 'maxItems: 1' and the other if 'minItems:
2'.

Rob