Re: [PATCH v3 06/12] of: address: Preserve the flags portion on 1:1 dma-ranges mapping

Herve Codina
2024-11-04T08:08:50Z

Hi Andrea,

On Mon, 28 Oct 2024 15:07:23 +0100
Andrea della Porta <andrea.porta@suse.com> wrote:

> A missing or empty dma-ranges in a DT node implies a 1:1 mapping for dma
> translations. In this specific case, the current behaviour is to zero out
> the entire specifier so that the translation could be carried on as an
> offset from zero. This includes address specifier that has flags (e.g.
> PCI ranges).
> Once the flags portion has been zeroed, the translation chain is broken
> since the mapping functions will check the upcoming address specifier
> against mismatching flags, always failing the 1:1 mapping and its entire
> purpose of always succeeding.
> Set to zero only the address portion while passing the flags through.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>

Tested ok with my LAN966x PCI device.

Tested-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé