From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8761DF756 for ; Wed, 6 Nov 2024 12:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896110; cv=none; b=QpmlC2zLJIM0rqGJPMFkhtgsJw738TL8ihPHDyvGi05iLamABkBPh1GgmPB+Mkzq6993rH5KG78zcq+Y1InW+0vYgnVYqMT5OJCrHLTz42C6UNnIf5J+ofxStOMTOGTcNPwjL5pzTIAL3QK3dDf5bnT6U85BAX2rS/pPDwMr5zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896110; c=relaxed/simple; bh=22mEWvI6gKzd1z8uuif4HIEMa2HjcN13Aq6+BkotBAo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cIsBGSUZ5A2HmDJFxQaB4oLVk+QA9Omeo3RJxhXgqChfKmpDaj0egsmR8TWIo1yibiyH4w93h0snrHmZUgMa+gj/O0PELpa4VlJ0bbN1zfI6272KniE7dMBz2rZsch49UCrHwBN228OvE4gX5It3x4TZ8qEH5ZCP4Kk+jR1H/RA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GGzIxi9w; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GGzIxi9w" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2fb51e00c05so97103341fa.0 for ; Wed, 06 Nov 2024 04:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730896107; x=1731500907; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=iWIaYuWanDJCXpP4xKD1ILcaU1UBHWm0pC+lsLc+oFM=; b=GGzIxi9wSjK7EMLAQNNRGmx+pgC1QgBi54CMvKZmndWXcBWWQT/ZTjD0vSysyNKw5X c1s7eoHhJLBJdfnl3Sos36Y12HiugpBcok5kmjA3ldeA/aLiZuUtzg5hc1tcSY7f1Qc6 edj5GuOiDg26qVDx0mfFGBU8/pF49BW1lgSWnOMqHwoXMWSNaRsG5QYxhu8Zk/qa+Nwv G8gLR1TXnvfYSebIpWCPSluZHQ1OtDRTnMRXy7Xgp9vIW58c9MUjrzMvvqz/Pp3iDGVQ Kv9WtjWAgQ4lsfXdUirGUQakHl0frudojCg0Ece6j0fXbIu3/bePCJOhoP94FexYvYAH D5Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730896107; x=1731500907; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iWIaYuWanDJCXpP4xKD1ILcaU1UBHWm0pC+lsLc+oFM=; b=kqAd+aAX5JBf/tsxLtTEiKQSMolc94WOadUd1NOh8ABcdWuZeljj59H/1XVV258uh5 0rPR24ZkPOU0AaLweoO7PPGBXtNzjdqtwwf3kYBP3Ra5Ae4U6B8DbpcyuwhY6r1zbm3Z 45K4M9t/kkGKhk6FdX415FQKrmxWtFl9ZHy7QOXvMnneEyhhn9wNwypTXJzbp4QoTqot 5xFqvNlVd2sRFRchuAOA5mtJuysgGX/ezR6Y5WeoT40a7/PwDZuecd1aURRioUcMVo+v /AopWKVM/Bp+sAkYXPPKir1WebXvGRTHSgsQ7W0Kf5eO3x2fNPKz8n4ABQZuVknTP0YK HZxA== X-Forwarded-Encrypted: i=1; AJvYcCV+hBrEpoPIXl1sdWz5zmi4NJeE748Kad2YuLA4aj7Xu/dCJtTfnwvQkC9HwQwggicsMmdKdrknkD4=@vger.kernel.org X-Gm-Message-State: AOJu0YzuUrXCJ8D6D/hJ0LAPb1BPd+bRzleAObGguVqj3Sst9UymZWfd YQ1k9nLLeYeHRbEeGNUtaMf20OeVgq2bvVp7GfaxaPlx4qlCOOpQAVpV0uBL6T8= X-Google-Smtp-Source: AGHT+IH01edGD9WqoLaLqcgKuDB7Exq8qeJnSC4L0C1q00at8YKTkQgYxMxULRDTQH3U47fkcdWNvw== X-Received: by 2002:a2e:a545:0:b0:2fa:fcf0:7c2a with SMTP id 38308e7fff4ca-2fedb7ca5b3mr158144621fa.24.1730896106943; Wed, 06 Nov 2024 04:28:26 -0800 (PST) Received: from localhost (host-79-35-211-193.retail.telecomitalia.it. [79.35.211.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9eb17d0adasm272575766b.111.2024.11.06.04.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 04:28:26 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Wed, 6 Nov 2024 13:28:52 +0100 To: Andrea della Porta Cc: Stanimir Varbanov , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v3 09/12] arm64: dts: rp1: Add support for RaspberryPi's RP1 device Message-ID: References: <1f4cec50493ec5d3168735c0a005771787e5cd59.1730123575.git.andrea.porta@suse.com> <4a474dae-6669-4678-87dd-e0e9692a749b@suse.de> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Stan, On 15:31 Tue 05 Nov , Andrea della Porta wrote: > Hi Stan, > > On 15:29 Mon 04 Nov , Stanimir Varbanov wrote: > > Hi Andrea, > > ... > > shouldn't this be: > > > > rp1_clocks: clocks@18000 { > > reg = <0x00 0x00018000 0x0 0x10038>; > > ... > > } > > > > ? > > > > And for other nodes too... > > For that to be @18000 instead of @c040018000, you should also change > the "ranges" entry in pci-ep-bus node, as follows: > > ranges = <0x00 0x00018000 //This was: 0xc0 0x40000000 > 0x01 0x00 0x00000000 > 0x00 0x00400000>; > > which is of course feasible, but I prefer to use addresses that > resemble (at least to some extent) the ones in RP1 docs. > > Many thanks, > Andrea Sorry, this should be like this ranges = <0x00 0x00000000 //This was: 0xc0 0x40000000 0x01 0x00 0x00000000 0x00 0x00400000>; i.e. the child address in the range should be 0 and not 0x18000. Anyway you got the point: in theory we can replace that address with whatever placeholder we want and from a functional perspective, it will work, as long as you change all the relevant mappings. After some brainstorming we've decided to choose a simpler scheme that will resemble more the internal address described in the RP1 reference manual. 0xC040000000 will become 0x40000000. Many thanks, Andrea ...