Re: [PATCH v3 04/12] dt-bindings: misc: Add device specific bindings for RaspberryPi RP1

Manivannan Sadhasivam
2024-11-06T14:50:26Z

On Mon, Oct 28, 2024 at 03:07:21PM +0100, Andrea della Porta wrote:
> The RP1 is a MFD that exposes its peripherals through PCI BARs. This
> schema is intended as minimal support for the clock generator and
> gpio controller peripherals which are accessible through BAR1.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> .../devicetree/bindings/misc/pci1de4,1.yaml | 80 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml
>
> diff --git a/Documentation/devicetree/bindings/misc/pci1de4,1.yaml b/Documentation/devicetree/bindings/misc/pci1de4,1.yaml
> new file mode 100644
> index 000000000000..d66b2fc130d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/pci1de4,1.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/pci1de4,1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RaspberryPi RP1 MFD PCI device
> +
> +maintainers:
> + - Andrea della Porta <andrea.porta@suse.com>
> +
> +description:
> + The RaspberryPi RP1 is a PCI multi function device containing
> + peripherals ranging from Ethernet to USB controller, I2C, SPI
> + and others.
> + The peripherals are accessed by addressing the PCI BAR1 region.
> +
> +allOf:
> + - $ref: /schemas/pci/pci-ep-bus.yaml
> +
> +properties:
> + compatible:
> + additionalItems: true
> + maxItems: 3
> + items:
> + - const: pci1de4,1
> +
> + '#interrupt-cells':
> + const: 2
> + description:
> + Specifies respectively the interrupt number and flags as defined
> + in include/dt-bindings/interrupt-controller/irq.h.
> +
> + interrupt-controller: true
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - '#interrupt-cells'
> + - interrupt-controller
> + - pci-ep-bus@1
> +
> +examples:
> + - |
> + pci {
> + #address-cells = <3>;
> + #size-cells = <2>;
> +
> + rp1@0,0 {
> + compatible = "pci1de4,1";
> + ranges = <0x01 0x00 0x00000000
> + 0x82010000 0x00 0x00
> + 0x00 0x400000>;

Could you please have the 'ranges' in a single line as used everywhere?

- Mani

> + #address-cells = <3>;
> + #size-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + pci_ep_bus: pci-ep-bus@1 {
> + compatible = "simple-bus";
> + ranges = <0xc0 0x40000000
> + 0x01 0x00 0x00000000
> + 0x00 0x00400000>;
> + dma-ranges = <0x10 0x00000000
> + 0x43000000 0x10 0x00000000
> + 0x10 0x00000000>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + rp1_clocks: clocks@c040018000 {
> + compatible = "raspberrypi,rp1-clocks";
> + reg = <0xc0 0x40018000 0x0 0x10038>;
> + #clock-cells = <1>;
> + clocks = <&clk_rp1_xosc>;
> + clock-names = "xosc";
> + };
> + };
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ccf123b805c8..2aea5a6166bd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19384,6 +19384,7 @@ RASPBERRY PI RP1 PCI DRIVER
> M: Andrea della Porta <andrea.porta@suse.com>
> S: Maintained
> F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
> +F: Documentation/devicetree/bindings/misc/pci1de4,1.yaml
> F: Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
> F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml
> F: include/dt-bindings/clock/rp1.h
> --
> 2.35.3
>

--
மணிவண்ணன் சதாசிவம்