Re: [PATCH v3 02/12] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings

Krzysztof Kozlowski
2024-11-07T11:57:42Z

On 04/11/2024 12:11, Andrea della Porta wrote:

>>>>
>>>> Your example does not use any subnodes, so this looks not needed.
>>>
>>> The example has subnodes, as in the following excerpt from the example:
>>
>> I meant, you do not need properties in subnodes (1st level). You only
>> want properties in subnodes of subnodes, so 2nd level. What is the point
>> of allowing them in 1st level?
>
> I will add those two sub-nodes to the example:
>
> rp1-i2s0-default-state {
> function = "i2s0";
> pins = "gpio18", "gpio19", "gpio20", "gpio21";
> bias-disable;
> };
>
> rp1-uart0-default-state {
> txd-pins {
> function = "uart0";
> pins = "gpio14";
> bias-disable;
> };
>
> rxd-pins {
> function = "uart0";
> pins = "gpio15";
> bias-pull-up;
> };
> };
>
> The first is just a group of pins with the same settings, the second is
> a pin group with different settings per pin. This is basically the same
> usage as in qcom,sm4250-lpass-lpi-pinctrl.yaml.
>

Ack, that's ok then.

Best regards,
Krzysztof