From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>, Pengfei Li <pengfei.li_1@nxp.com>
Cc: krzk+dt@kernel.org, robh@kernel.org, abelvesa@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, ping.bai@nxp.com,
ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com,
frank.li@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver
Date: Fri, 20 Sep 2024 15:27:26 +0200 [thread overview]
Message-ID: <a07828a4-8040-42cb-8c62-8939cac4d9de@kernel.org> (raw)
In-Reply-To: <ZtAeGWtJDMyTVkjc@linaro.org>
On 29/08/2024 09:07, Abel Vesa wrote:
> On 24-06-27 16:24:24, Pengfei Li wrote:
>> 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
>> indicate the number of clocks, but it is not part of the ABI, so
>> it should be moved to clk driver.
>>
>
> Right, why?
>
> All other providers have been using the _CLK_END from the bindings
> header. What is so special about this ? AFAICT, nothing.
Because usually we do no consider number of clocks as an ABI. For
starters it does no really appear in DTS. But what's more important -
new clocks are described later, which contradicts this define. So either
this is an ABI or it is not. If it is, you are not allowed to add any
new clock. If it is not, then this should have never been part of bindings.
We did the same (removal of END/NUM macros) for several other platforms
already.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-20 13:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 8:24 [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver Pengfei Li
2024-06-27 8:24 ` [PATCH v2 1/2] " Pengfei Li
2024-06-28 7:38 ` Krzysztof Kozlowski
2024-06-29 2:49 ` Pengfei Li
2024-07-19 6:08 ` Pengfei Li
2024-07-20 18:28 ` Krzysztof Kozlowski
2024-08-06 8:36 ` Pengfei Li
2024-08-06 9:39 ` Krzysztof Kozlowski
2024-09-24 22:54 ` Pengfei Li
2024-09-24 7:56 ` Krzysztof Kozlowski
2024-10-09 11:51 ` Abel Vesa
2024-10-11 5:10 ` Pengfei Li
2024-06-27 8:24 ` [PATCH v2 2/2] dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition Pengfei Li
2024-06-27 15:15 ` Conor Dooley
2024-08-29 7:07 ` [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver Abel Vesa
2024-09-20 13:27 ` Krzysztof Kozlowski [this message]
2024-09-21 0:04 ` Pengfei Li
2024-10-08 19:47 ` Pengfei Li
2024-10-10 10:58 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07828a4-8040-42cb-8c62-8939cac4d9de@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=pengfei.li_1@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox