Re: [PATCH 3/4] clk: qcom: Add defaults for desired arm64 drivers

[Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>]

On 16/04/2026 10:30, Konrad Dybcio wrote:
> On 4/16/26 10:10 AM, Krzysztof Kozlowski wrote:
>> Clock controller drivers are essential for booting up SoCs and are not
>> really optional for a given platform.  Kernel should not ask users
>> choice of drivers when that choice is obvious and known to the
>> developers that answer should be 'yes' or 'module'.
>>
>> Enable drivers for upstreamed or being upstreamed SoCs, which are not
>> yed enabled in defconfig: Glymur, Nord, SC7180, SC8180X, SC8280XP,
>> SC7280, QDU1000, SM4450, SM7150, SM8150, SM8450, SM6125, SM6375.  Note
>> that main GCC clock controller drivers are usually already enabled for
>> these.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>>  	tristate "Nord Global Clock Controller"
>>  	depends on ARM64 || COMPILE_TEST
>>  	select QCOM_GDSC
>> +	default ARCH_QCOM
>>  	help
>>  	  Support for the global clock controller on Nord devices.
>>  	  Say Y if you want to use peripheral devices such as UART,
> 
> So Nord GCC is "desired", but Kaanapali GCC is "important"? ;)

The difference is only what was already in defconfig thus which change
has impact on autoconf.h.

There is no upstream user of Nord GCC, thus I would not call it
important yet. I predict there will be such user, thus it is desired
just like every new SoC.

> 
> In any case, as far as I'm concerned patches 2 and 3 could be one

Much easier to test impact on autoconf and resulted image when changes
supposedly transparent are really separate.

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Best regards,
Krzysztof